? Pending

User tests: Successful: Unsuccessful:

avatar Hackwar
Hackwar
29 Jun 2018

This is a PR to enable #20571.

FinderIndexerHelper::getContentPath() is supposed to create the SEFed URL of the content item while indexing the content item. However, that doesn't really work for several reasons. First of all, there are component routers out there, that fail in the wrong circumstances, like being run in the backend. Then there are the issues of permissions. The user running the indexer (either by batch indexing in the backend or by saving a content item) in general has other permissions than a guest user and thus might see menu items that the guest user does not see. Last but not least, Smart Search does not really know anything about the routing system and thus also does not know when to update that data, thus we already have the wrong data in the DB when a user creates an article and then links it via a menu item.

Long story short: We have to create the right route on runtime and thus can't pre-compute this. That is why we haven't used the data from that in com_finder ever. Which is why this method is being deprecated here.

avatar Hackwar Hackwar - open - 29 Jun 2018
avatar Hackwar Hackwar - change - 29 Jun 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 29 Jun 2018
Category Administration com_finder
avatar mbabker mbabker - close - 29 Jun 2018
avatar mbabker mbabker - merge - 29 Jun 2018
avatar mbabker mbabker - change - 29 Jun 2018
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2018-06-29 23:15:18
Closed_By mbabker
Labels Added: ?

Add a Comment

Login with GitHub to post a comment