?
avatar byungwook-kim
byungwook-kim
29 Jun 2018

Steps to reproduce the issue

during PR, the following error is occurred on drone CI

+-- karma-firefox-launcher@0.1.7
+-- karma-jasmine@0.3.8
+-- karma-jasmine-ajax@0.1.13
| -- jasmine-ajax@3.4.0 +-- karma-requirejs@1.1.0 +-- karma-verbose-reporter@0.0.3 +-- requirejs@2.3.5-- text@2.0.15 (git://github.com/requirejs/text.git#d04de4ffd7bf5ba6cb80cdca2d40d4f6f52a1b1f)

npm WARN optional Skipping failed optional dependency /chokidar/fsevents:
npm WARN notsup Not compatible with your operating system or architecture: fsevents@1.2.4

Suites and tests results:

Browser results:

Expected result

No errors expected

Actual result

System information (as much as possible)

Additional comments

I have not modified any javascript files on PR.

avatar byungwook-kim byungwook-kim - open - 29 Jun 2018
avatar joomla-cms-bot joomla-cms-bot - change - 29 Jun 2018
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 29 Jun 2018
avatar franz-wohlkoenig franz-wohlkoenig - change - 29 Jun 2018
Category CLI
avatar zero-24
zero-24 - comment - 29 Jun 2018

Hi :)

I have just rebooted the build and it seams to be better now: http://ci.joomla.org/joomla/joomla-cms/6811/5

I think we can close this issue than?

avatar mbabker
mbabker - comment - 29 Jun 2018

It really should be fixed permanently. The constant false positives from Drone about this particular JavaScript test and the one that hangs AppVeyor on PHP 5.6 need review because a lot of times it just results in either testers passing over items because they see red X's on the CI integrations or reviewers merging without looking for "real" failures because Travis is green (which rarely gives these false positives) but the other systems aren't.

avatar brianteeman
brianteeman - comment - 29 Jun 2018

Pretty sure the failure here is not related to the PR http://ci.joomla.org/joomla/joomla-cms/6815/14

avatar franz-wohlkoenig franz-wohlkoenig - change - 30 Jun 2018
Status New Discussion
avatar zero-24
zero-24 - comment - 30 Jun 2018

JS != System Tests. This issue here was about the JS tests not the System tests. For the system tests please try to update your branch as a fix should be merged for that already.

avatar byungwook-kim
byungwook-kim - comment - 2 Jul 2018

Okay, I will close the issue.

avatar byungwook-kim byungwook-kim - change - 2 Jul 2018
Status Discussion Closed
Closed_Date 0000-00-00 00:00:00 2018-07-02 00:17:17
Closed_By byungwook-kim
avatar byungwook-kim byungwook-kim - close - 2 Jul 2018
avatar mbabker
mbabker - comment - 4 Jul 2018

Re-opening. Someone needs to fix this test so it stops creating false positives on so many PRs or just flat out remove the test since it seems so critically broken.

avatar mbabker mbabker - change - 4 Jul 2018
Status Closed New
Closed_Date 2018-07-02 00:17:17
Closed_By byungwook-kim
avatar mbabker mbabker - reopen - 4 Jul 2018
avatar franz-wohlkoenig franz-wohlkoenig - change - 4 Jul 2018
Status New Discussion
avatar mbabker
mbabker - comment - 21 Jul 2018

Re-closing, same reason as #21050 (comment)

Looks like failures are just going to keep being ignored.

avatar mbabker mbabker - close - 21 Jul 2018
avatar mbabker mbabker - change - 21 Jul 2018
Status Discussion Closed
Closed_Date 0000-00-00 00:00:00 2018-07-21 01:02:09
Closed_By mbabker

Add a Comment

Login with GitHub to post a comment