[#2092] - MySQL(i) db collation check was not actually querying the database default collation
- Closed
- 11 Jul 2014
- Medium
- Build: master
- # 2092
- Diff
- pollen8:db-collation
- Error This pull request is targeted at the master branch. Pull requests should no longer be merged to master.
User tests: Successful: Unsuccessful:
This patch checks the actual db collation first, and if not found falls back to the previous method of querying the first db table's first column's collation.
Issue with the previous method is that if you had a table with a field whose collation was not the same as the db's default collation the method would return the wrong result.
I looked at this request, but the file libraries/joomla/database/driver/mysqli.php seem to be changed since october 2013 so i can't test it. can you please update your PR
See #3886 for an updated PR
See http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=32131&start=0
Thanks for your contribution - At this time we are only using github as the place to submit code fixes, the actual reporting of issues and testing fixes is still taking place on Joomlacode.
Please can you:
1) Open an item on the Joomlacode tracker in the appropriate area.
CMS Bug Reports: http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemBrowse&tracker_id=8103
CMS Feature Requests: http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemBrowse&tracker_id=8549
2) After submitting the item to the Joomlacode tracker, add a link to the Joomlacode tracker item here and make sure that you add a link to this GitHub issue or pull request on the joomlacode tracker item.