[#20906] - FIX: Install Languages Manager language badges wrongly set to not match since upgrade to 3.8.10
- Fixed in Code Base
- 29 Jun 2018
- Medium
- Build: staging
- # 20906
- Diff
- infograf768:lang_badge
User tests: Successful: Unsuccessful:
As title says.
Summary of Changes
the code in the Install Languages template was counting substrings. Switching to a count of 6 created the bug.
Replacing the entire line by the same code we use when installing languages at Joomla install time solves the issue.
Testing Instructions
Load administrator/index.php?option=com_installer&view=languages
Before patch
After patch
Documentation Changes Required
None
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_installer |
I have tested this item
The Patch has been tested successfully. Please review my earlier response with screenshot.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20906.
Before accepting this change we must understand what change caused this. The file itself has not changed for a long time so the cause is elsewhere and may effect other things. We have to stop applying band aids, they come off in the wash.
Read the code.
The reason is the version switch from 3.x.x to 3.x.xx
We had
<?php if (substr($language->version, 0, 3) != $minorVersion || substr($language->version, 0, 5) != $currentShortVersion) : ?>
substr($language->version, 0, 5) was OK when version was below 10 as 3.8.x is equal to 5.
as soon as we switched to 3.8.10 we have 6 substrings which evidently kills this code.
The code in installation which is used now in this PR does not take into account the number of substrings.
This patch works, but
Is below condition required?
strpos($language->version, $minorVersion) !== 0 || // '3.8.10.1' starts with '3.8'After that we compare whole version, e.g. '3.8.10.1' starts with '3.8.10'
I have tested this item
Patch works fine for the install languages list. Correctly shows in green after patch applied.
- But, the main language view have the same issue, even for English. Should this be fixed in this same issue?
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20906.
| Labels |
Added:
?
|
||
| Category | Administration com_installer | ⇒ | Administration com_installer com_languages |
@ot2sen @imanickam
Done.
I have tested this item
Tested the revised patch and found that all the three screens (listed below) display the color of the language version labels correctly:
Extensions: Install Languages
Languages: Installed (Administrator)
Lanugages: Installed (Site)
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20906.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20906.
I have tested this item
Both lists works fine now after last update of PR
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20906.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20906.
mbabker
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-06-29 01:39:51 |
| Closed_By | ⇒ | mbabker | |
| Labels |
Added:
?
|
||
#20906 I have tested this successfully (using Joomla! 3.8.10).
Please review the image attached.