love it, will give it a test soon ?

Can add filters to the new fields, or in this case is not necessary? following what doing in others PRs

Sorry I don't understand

No, all this is doing is pre-setting the filters that already exit on a page.
On 27 Jun 2018, 14:05 +0100, Carlos Rodriguez notifications@github.com, wrote:

Can we add filters to the new fields, or in this case is not necessary? following what doing in others PRs
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

He's talking about input filters (essentially JFactory::getApplication()->input->get('foo', 'default', $filter);, not the UI filters.

Then of course it is possible as we are just passing the request variables. But in doing that, you have no control over the filters on that page if you pass them in and they work. Note, I haven’t tried filtering the admin ui with filters not existent on the UI. But wouldn’t really advise it.
On 27 Jun 2018, 14:28 +0100, Michael Babker notifications@github.com, wrote:

He's talking about input filters (essentially JFactory::getApplication()->input->get('foo', 'default', $filter);, not the UI filters.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

You're still missing the point here I'm afraid.

The filter="whatever" attribute sets what data type something is filtered/validated as when it is read from the request in the JForm API when filtering/validating data. So if you set filter="int" on a field, then when the field's data is read from the request it is filtered/validated as an integer.

Ah, clearly I missed that. I just saw the filter on custom fields.
On 27 Jun 2018, 14:35 +0100, Michael Babker notifications@github.com, wrote:

You're still missing the point here I'm afraid.
The filter="whatever" attribute sets what data type something is filtered/validated as when it is read from the request in the JForm API when filtering/validating data. So if you set filter="int" on a field, then when the field's data is read from the request it is filtered/validated as an integer.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

@tonypartridge Sorry for no explain well when i ask about this. Thank you @mbabker

Gotya. Will update.

@SharkyKZ can you check the filters please

When you create an admin menu item to display a list of all articles there is no option to select a filter so the article list displays all the articles.

So, this is well covered in this PR. Except, not for the Statue and Access levels. Also, will be good do the same with the featured articles view

I did think about status and access but there is no point. A users ACL addresses the access and I don't want to pre-filter on status - thats not a good idea.

As for the featured view thats a special type of thing and it doesnt match the use case for this - my 2c

Roger that. So, this work perfect!

I have tested this item ✅ successfully on 921f0e1

Filters OK.

I actually think the access level could be handy for when filtering lots of articles assigned to certain access levels, i.e. ‘Guest Articles’, ‘Members Articles’. ?

Just a thought
On 27 Jun 2018, 15:38 +0100, Brian Teeman notifications@github.com, wrote:

I did think about status and access but there is no point. A users ACL addresses the access and I don't want to pre-filter on status - thats not a good idea.
As for the featured view

If approved I will create the same option for other components
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

@tonypartridge ah - I was thinking of ACL and not access levels - i will add it

I have tested this item ✅ successfully on 8284fd0

I have tested this item ✅ successfully on aa76e5b

RTC

RTC

Thanks for merging. I will add the same for other components now.

Thanks for this effort Brian et al,.. to make this thing really sing, is it possible to add 'Category Template Layout' selector to the new category menu item ?

The Category Menu already has 'template selector', but it only works on single articles and not the category list/blog files (because the list/blog is inherently the category template via an XML file ).
#19613

Perhaps create a new menu item called "Category (templateable)" so all the old stuff is compatible, and then allow it to properly override both the category and article layouts.. ?

@helpwise can you please open a new Issue (and Link to this PR) as Comments on closed Issues didn't get much Notice?

Oh - yes - sorry! :)