PR-staging

Pending

User tests: Successful: Unsuccessful:

avatar mbabker
mbabker
26 Jun 2018

Pull Request for Issue #20875

Summary of Changes

As part of the security fixes in 3.8.9, the autoloader no longer allows inclusion of files outside of a namespace or prefix path. This is in part enforced by a string comparison of the resolved file path and the base path, however as this is a string comparison it needs to take into consideration the operation system directory separator and that was not happening. In effect, it was comparing C:\xampp\htdocs\j389\libraries\cms\class\loader.php against C:\xampp\htdocs\j389/libraries/cms/class/loader.php.

Testing Instructions

Apply patch. Autoload files. Rejoice while I go through the pain of building a new release.

avatar mbabker mbabker - open - 26 Jun 2018
avatar mbabker mbabker - change - 26 Jun 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 26 Jun 2018
Category Libraries
avatar joomdonation joomdonation - test_item - 26 Jun 2018 - Tested successfully
avatar joomdonation
joomdonation - comment - 26 Jun 2018

I have tested this item successfully on 4962d8d

It solves the issue. Navigate to random pages and it worked OK. Tried to create article and it worked, too.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20877.

avatar ggppdk
ggppdk - comment - 26 Jun 2018

Looks like it is working again on windows, frontend and backend

avatar toivo
toivo - comment - 26 Jun 2018

This item resuscitated my test sites, too.

avatar laoneo laoneo - change - 26 Jun 2018
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2018-06-26 15:17:59
Closed_By laoneo
Labels Added: PR-staging
avatar laoneo laoneo - close - 26 Jun 2018
avatar laoneo laoneo - merge - 26 Jun 2018
avatar laoneo
laoneo - comment - 26 Jun 2018

Thanks @mbabker for the fast help!

avatar laoneo
laoneo - comment - 26 Jun 2018

And a thank you to all the testers!

avatar 4dsiao
4dsiao - comment - 26 Jun 2018

How to download the latest file for loader.php

avatar mbabker
mbabker - comment - 26 Jun 2018

Install packages from https://github.com/joomla/joomla-cms/releases/tag/3.8.10 until update server is ready.

avatar 4dsiao
4dsiao - comment - 26 Jun 2018

Thanks and had updated to 3.8.10 and my site is back online...

avatar toivo
toivo - comment - 26 Jun 2018

Thanks, update to 3.8.10 on Windows worked without issues.

avatar Shape77
Shape77 - comment - 26 Jun 2018

I have issues since 3.8.9 update: in Menu, when I try to create a new menu item or edit a old one I have this error:
Cannot use object of type stdClass as array

This morning I created new menu items in 3.8.8 and had no problem at all.

avatar brianteeman
brianteeman - comment - 26 Jun 2018

@Shape77 are you using PWT Sitemap?
#20874 (comment)

avatar Shape77
Shape77 - comment - 26 Jun 2018

@brianteeman Nope, I use JSitemap PRO

avatar wildfox76
wildfox76 - comment - 26 Jun 2018

I have same problems of anothe user... issues since 3.8.9 update: in Menu, when I try to create a new menu item or edit a old one I have this error:
Cannot use object of type stdClass as array

Try this upgrade on 4 sites and same error, please fix it soon, regards!!!

avatar wojsmol
wojsmol - comment - 26 Jun 2018

@wildfox76 This is related to plugins installed on this sites - please see discussion in this issue #20879.

avatar pbirch31
pbirch31 - comment - 27 Jun 2018

Does this have any effect on what is causing Users to have to Login twice to the site?

avatar Bakual
Bakual - comment - 27 Jun 2018

This PR is merged and released already in Joomla version 3.8.10.
If you still have an issue after upgrading to 3.8.10, please open a new issue.

Add a Comment

Login with GitHub to post a comment