? Pending

User tests: Successful: Unsuccessful:

avatar ciar4n
ciar4n
25 Jun 2018

Pull Request for Issue #15279 .

Summary of Changes

Adds HTML classes using the following standard to com-content frontend views.

ExtensionType-Extension(-SubExtension)(-View) (Eg. 'com-content-category-blog`).

Note: If the default view then -View is omitted. If only one SubExtension exists or if the SubExtension matches the Extension then -SubExtension is omitted.

Child views and child elements within the views

BEM class naming is adopted..

ExtensionType-Extension__Element.

For B/C, old classes remain.

Testing Instructions

Code review.

Expected result

All works fine

Actual result

All works fine

Documentation Changes Required

Yes

avatar ciar4n ciar4n - open - 25 Jun 2018
avatar ciar4n ciar4n - change - 25 Jun 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 25 Jun 2018
Category Front End com_content
avatar ciar4n ciar4n - change - 26 Jun 2018
Labels Added: ?
avatar Quy Quy - test_item - 27 Jun 2018 - Tested successfully
avatar Quy
Quy - comment - 27 Jun 2018

I have tested this item successfully on 4aab132


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20863.

avatar laoneo laoneo - change - 27 Jun 2018
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2018-06-27 04:47:39
Closed_By laoneo
avatar laoneo laoneo - close - 27 Jun 2018
avatar laoneo laoneo - merge - 27 Jun 2018

Add a Comment

Login with GitHub to post a comment