Feeling Lucky
?
?
[#20861] - [4.0] HTML class naming standard [frontend][com-finder]
- Fixed in Code Base
- 26 Jun 2018
- Medium
- Build: 4.0-dev
- # 20861
- Diff
- ciar4n:class-naming-com-finder
User tests: Successful: Unsuccessful:
Pull Request for Issue #15279 .
Summary of Changes
Adds HTML classes using the following standard to com-finder frontend views.
ExtensionType-Extension(-SubExtension)(-View) (Eg. 'com-finder`).
Note: If the default view then -View is omitted. If only one SubExtension exists or if the SubExtension matches the Extension then -SubExtension is omitted.
Child views and child elements within the views
BEM class naming is adopted..
- Block (https://en.bem.info/methodology/quick-start/#block):
ExtensionType-Extension(-View) - Element (https://en.bem.info/methodology/quick-start/#element): Child view/element
ExtensionType-Extension__Element.
For B/C, old classes remain.
Testing Instructions
Code review.
Expected result
All works fine
Actual result
All works fine
Documentation Changes Required
Yes
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End com_finder |
| Labels |
Added:
?
|
||
Quy
- comment
- 25 Jun 2018
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20861.
| Status | Pending | ⇒ | Ready to Commit |
Quy
- comment
- 25 Jun 2018
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20861.
wilsonge
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-06-26 10:02:28 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
I have tested this item✅ successfully on 19c5fc6
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20861.