J3 Issue ?
avatar carlitorweb
carlitorweb
23 Jun 2018

Steps to reproduce the issue

  • Go to Menu - Options and put to Yes the option Show Page Heading and write a global Page Heading in the option below. Save.
  • Go to a menu item (preferably one that leads to an article), and check inside the Page Display the option Show Page Heading is set to Use Global (Yes) or simply Yes, also check you have the option Page Heading empty, in this way, the global value is taken. Save.

Expected result

In the frontend, the global Page Heading values it is shown.

Actual result

In the frontend, the global Page Heading values it is not shown. Instead, the title of the menu item is taken, as a page heading.

screenshot_20180623095031
screenshot_20180623095100

System information (as much as possible)

Last staging

avatar carlitorweb carlitorweb - open - 23 Jun 2018
avatar joomla-cms-bot joomla-cms-bot - change - 23 Jun 2018
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 23 Jun 2018
avatar franz-wohlkoenig franz-wohlkoenig - change - 23 Jun 2018
Category com_menus
avatar brianteeman brianteeman - change - 23 Jun 2018
Labels Added: J3 Issue
avatar brianteeman brianteeman - labeled - 23 Jun 2018
avatar DavidBoggitt
DavidBoggitt - comment - 23 Jun 2018

There's also a typo with GLOBLA HEADING

avatar carlitorweb
carlitorweb - comment - 23 Jun 2018

@DavidBoggitt I wrote that wrong when I did in the global option.

screenshot_20180623145545

avatar DavidBoggitt
DavidBoggitt - comment - 24 Jun 2018

Ah, ok :)

avatar ReLater
ReLater - comment - 24 Jun 2018

In the frontend, the global Page Heading values it is not shown. Instead, the title of the menu item is taken, as a page heading.

That's the expected behavior. But, you are right! The settings are irritating because very very seldom a situation occurs where the global Page Heading is shown. It's something like a fallback I think.

I think one would need an additional option/parameter "Show always the global Page Heading" to stay B\C. But if the global Page Heading is not filled what then? Show the sitename or the menu title or ....?

Maybe just extending the description for the global "Page Heading"? At the moment it's described as an "alternative".

avatar franz-wohlkoenig franz-wohlkoenig - change - 24 Jun 2018
Status New Discussion
avatar carlitorweb
carlitorweb - comment - 24 Jun 2018

That's the expected behavior

I think not @ReLater . If I define a global page heading, that is the one need shown if i leave the page heading of the menu item empty, and no the title of the menu item.

Yes, I know, are minimal cases of use of this option, but we have there, and no work as need work. I'm looking for where this value is overwritten, but still a lot to learning about J . Where do you suggest I look for find this issue?

avatar ReLater
ReLater - comment - 24 Jun 2018

Ok, maybe it's not the expected behavior but it's the way Joomla is working for a long time now (if we are talking about articles). That's why I've added the B\C remark.

But maybe you're right.

Where do you suggest I look for find this issue?

Normally the last decision concerning page_heading is made in view.html.php. E.g. for com_content:
https://github.com/joomla/joomla-cms/blob/3.8.8/components/com_content/views/article/view.html.php#L229-L238

Search also for merge(...)-calls in the article model and view.html.php to find the lines where params are merged (= "overwritten by others")!

During a quick&dirty debug I couldn't find a place where the global page_heading occurs in any params.

avatar carlitorweb
carlitorweb - comment - 25 Jun 2018

Thank @ReLater

avatar brianteeman
brianteeman - comment - 25 Jun 2018

From my perspective the error is that there is the option to set PAGE HEADING in the global options. That option is only intended to be an override to the default text (if show page heading is on) so you would only ever set it on a menu item and not globally

avatar carlitorweb
carlitorweb - comment - 25 Jun 2018

By default, every menu item, come with Use Global, so, in terms of saving time, this option can help you. But the reality is this option almost does not have many cases of uses, so I agree, it is unnecessary. But, we canĀ“t remove, because of B/C right?

avatar brianteeman
brianteeman - comment - 25 Jun 2018

If the field "Page Heading" is never used (as opposed to "Show Page Heading") then it probably can be removed. BUT just in case someone was re-purposing that field for something else it would be classed as a B/C break so could only be removed in J4

avatar carlitorweb
carlitorweb - comment - 25 Jun 2018

Anyway, is not work now. And i not test on J4 yet, but sure there have same issue

avatar brianteeman
brianteeman - comment - 25 Jun 2018

As I said - its not so much it doesn't work as it shouldnt have been there in the first place. Its a copy&paste bug that it is offered as an option in the xml for the global

avatar SharkyKZ
SharkyKZ - comment - 13 Jul 2018

Global option is used when accessing components directly (without menu item). The issue is that Use Global placeholder was added to menu item form by mistake.

avatar SharkyKZ
SharkyKZ - comment - 13 Jul 2018

Test PR #21095 please.

avatar franz-wohlkoenig franz-wohlkoenig - change - 13 Jul 2018
Status Discussion Closed
Closed_Date 0000-00-00 00:00:00 2018-07-13 08:51:26
Closed_By franz-wohlkoenig
avatar joomla-cms-bot joomla-cms-bot - change - 13 Jul 2018
Closed_By franz-wohlkoenig joomla-cms-bot
avatar joomla-cms-bot joomla-cms-bot - close - 13 Jul 2018
avatar joomla-cms-bot
joomla-cms-bot - comment - 13 Jul 2018
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 13 Jul 2018

closed as having Pull Request #21095

Add a Comment

Login with GitHub to post a comment