? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
22 Jun 2018

I have started reviewing all the front end components and namespacing everything

Before I go any further with this could someone please check that I am doing it correctly

d29d184 22 Jun 2018 avatar brianteeman jlog
avatar brianteeman brianteeman - open - 22 Jun 2018
avatar brianteeman brianteeman - change - 22 Jun 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 22 Jun 2018
Category Front End com_ajax com_config com_contact com_content
avatar brianteeman brianteeman - change - 22 Jun 2018
Labels Added: ?
avatar brianteeman
brianteeman - comment - 22 Jun 2018

Ok thanks for checking and I will carry on and post back when it's ready

a987693 22 Jun 2018 avatar brianteeman JFile
878f5bb 22 Jun 2018 avatar brianteeman JPath
avatar joomla-cms-bot joomla-cms-bot - change - 22 Jun 2018
Category Front End com_ajax com_config com_contact com_content Front End com_ajax com_banners com_config com_contact
avatar brianteeman
brianteeman - comment - 22 Jun 2018

Please test and then we can get this merged before it gets into conflict

avatar brianteeman
brianteeman - comment - 23 Jun 2018

(The failing system test is unrelated to this PR)

avatar wilsonge
wilsonge - comment - 23 Jun 2018

@laoneo I can't view the entire diff with my hotels wifi (github says no after about 15 files :( ) can you review and merge if required please

avatar brianteeman
brianteeman - comment - 26 Jun 2018

Resolved conflicts

I have a feeling I am going to be saying this a lot

avatar brianteeman
brianteeman - comment - 26 Jun 2018

@wilsonge what have you done to me

avatar brianteeman
brianteeman - comment - 26 Jun 2018

Can someone either merge or reject this PR please - I really dont want to be resolving merge conflicts multiple times a day @laoneo @wilsonge

avatar laoneo
laoneo - comment - 27 Jun 2018

Perhaps you should consider to make smaller pr's. One per extension or so. Easier to review and we can merge faster.

avatar Quy Quy - test_item - 27 Jun 2018 - Tested successfully
avatar Quy
Quy - comment - 27 Jun 2018

I have tested this item successfully on 02ffef8


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20837.

avatar brianteeman
brianteeman - comment - 27 Jun 2018

Conflicts resolved again

avatar brianteeman
brianteeman - comment - 28 Jun 2018

Closing this as it's obviously not going to be merged and will spend even more time splitting it into multiple pr one for each component :(

avatar brianteeman brianteeman - change - 28 Jun 2018
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2018-06-28 10:45:03
Closed_By brianteeman
avatar brianteeman brianteeman - close - 28 Jun 2018

Add a Comment

Login with GitHub to post a comment