? Pending

User tests: Successful: Unsuccessful:

avatar ciar4n
ciar4n
20 Jun 2018

Pull Request for Issue #15279 .

Summary of Changes

Adds HTML classes using the following standard to com-users frontend views.

ExtensionType-Extension(-SubExtension)(-View) (Eg. mod-users-registration-complete).

Note: If the default view then -View is omitted. If only one SubExtension exists or if the SubExtension matches the Extension then -SubExtension is omitted.

Child views and child elements within the views

BEM class naming is adopted..

ExtensionType-Extension__Element.

For B/C, old classes remain.

Testing Instructions

Code review.

Expected result

All works fine

Actual result

All works fine

Documentation Changes Required

Yes

avatar ciar4n ciar4n - open - 20 Jun 2018
avatar ciar4n ciar4n - change - 20 Jun 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 20 Jun 2018
Category Front End com_users
avatar ciar4n ciar4n - change - 20 Jun 2018
The description was changed
avatar ciar4n ciar4n - edited - 20 Jun 2018
avatar ciar4n ciar4n - change - 20 Jun 2018
Title
HTML class naming standard [frontend][com-users]
[4.0] HTML class naming standard [frontend][com-users]
avatar ciar4n ciar4n - edited - 20 Jun 2018
avatar ciar4n ciar4n - change - 20 Jun 2018
The description was changed
avatar ciar4n ciar4n - edited - 20 Jun 2018
avatar wilsonge wilsonge - change - 21 Jun 2018
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2018-06-21 14:11:14
Closed_By wilsonge
Labels Added: ?
avatar wilsonge wilsonge - close - 21 Jun 2018
avatar wilsonge wilsonge - merge - 21 Jun 2018

Add a Comment

Login with GitHub to post a comment