?
avatar david-bettondesign
david-bettondesign
20 Jun 2018

Steps to reproduce the issue

Create and publish an instance of mod_tags_similar (Tags - Similar).

Expected result

If the current page has other items with similar tags then those items will show in the list. If not then an error message will show stating "No matching tags." ( MOD_TAGS_SIMILAR_NO_MATCHING_TAGS ).

Actual result

If the current page has no items with similar tags then nothing shows (no message).

System information (as much as possible)

Joomla 3.8.8

Additional comments

The issue is caused by lines 24 to 27 of modules/mod_tags_similar/mod_tags_similar.php.
These lines can be removed because the default template accounts for an empty list and shows the error instead.

avatar david-bettondesign david-bettondesign - open - 20 Jun 2018
avatar joomla-cms-bot joomla-cms-bot - labeled - 20 Jun 2018
avatar franz-wohlkoenig franz-wohlkoenig - change - 20 Jun 2018
Category com_modules com_tags
avatar franz-wohlkoenig franz-wohlkoenig - change - 20 Jun 2018
Status New Confirmed
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 20 Jun 2018

Issue confirmed.

But i don't know if its expected that nothing is shown if there is no matching tag.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20810.

avatar Bakual
Bakual - comment - 20 Jun 2018

Imho it's expected that a module doesn't show up if it has nothing to show. Showing a message that there is nothing to show is quite useless ?

avatar joomla-cms-bot joomla-cms-bot - change - 20 Jun 2018
Status Confirmed Closed
Closed_Date 0000-00-00 00:00:00 2018-06-20 11:49:06
Closed_By joomla-cms-bot
avatar joomla-cms-bot joomla-cms-bot - close - 20 Jun 2018
avatar franz-wohlkoenig franz-wohlkoenig - change - 20 Jun 2018
Status Closed Expected Behaviour
Closed_By joomla-cms-bot franz-wohlkoenig
avatar joomla-cms-bot
joomla-cms-bot - comment - 20 Jun 2018
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 20 Jun 2018

Closed as expected Behaviour. Please reopen it if needed.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20810.

Add a Comment

Login with GitHub to post a comment