Feeling Lucky
?
[#20805] - Changed return 0 to continue
- Fixed in Code Base
- 20 Jun 2018
- Medium
- Build: staging
- # 20805
- Diff
- conflate-nl:staging
User tests: Successful: Unsuccessful:
To prevent the entire function to quit, it just needs to go to the next file.
Fix #17954
Pull Request for Issue #17954 .
Summary of Changes
Changed return 0 to continue
Testing Instructions
Create an install file and add multiple install sql files. The first one should be empty and the second one should have some sql. The second file is never executed
Expected result
The second file with queries should be executed
Actual result
The second file is not executed
Documentation Changes Required
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
MSnoeren1995
- comment
- 20 Jun 2018
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20805.
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-06-20 10:34:37 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
wilsonge
- comment
- 20 Jun 2018
Looks good to me! Thanks! Congrats on your first PR to Joomla :)
conflate-nl
- comment
- 20 Jun 2018
:-) Thanks!
I have tested this item✅ successfully on 1464229
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20805.