? ? Pending

User tests: Successful: Unsuccessful:

avatar SniperSister
SniperSister
19 Jun 2018

Summary of Changes

We have a new partnership for a static code analysis tool as mentioned here:
https://developer.joomla.org/news/739-rips-becomes-joomla-official-code-analysis-partner.html

This PR adds the tool to our CI pipeline.

Testing Instructions

Trigger a build in drone.

Expected result

Works.

avatar SniperSister SniperSister - open - 19 Jun 2018
avatar SniperSister SniperSister - change - 19 Jun 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 19 Jun 2018
Category Unit Tests
avatar brianteeman
brianteeman - comment - 19 Jun 2018

I assume the results will not be public?

avatar SniperSister
SniperSister - comment - 19 Jun 2018

I assume the results will not be public?

Yes, for obvious reasons ;) if an issue is found, the CI job will tell the dev to reach out to the security team so we can check.

avatar SniperSister SniperSister - change - 19 Jun 2018
Labels Added: ? ?
avatar brianteeman
brianteeman - comment - 19 Jun 2018

Does that mean that it will be visible to the public if something has been referred even if it we dont know what?

avatar SniperSister
SniperSister - comment - 20 Jun 2018

Yes

avatar brianteeman
brianteeman - comment - 20 Jun 2018

So for me thats a problem. If I create a PR to tweak some current code then the analysis will run. It detects an issue which might be in the current code as well as the change. Then there is public notification that there is a security issue in this code which might be in the current release. So now we have announced to the world that a security issue exists in this code block.

Or do I misunderstand you

avatar SniperSister
SniperSister - comment - 20 Jun 2018

So now we have announced to the world that a security issue exists in this code block.

The scanner always checks the complete codebase, not just the changed lines - so the feedback is only "there might be an issue somewhere in the global codebase".

Besides that the procedure for an issue in the current codebase (unrelated to the PR) would be that we mark the issue as "known" in the scanning tool, rerun the scan (which will then succeed) and we can give the PR-owner the feedback that this has been a false-positive and has been fixed. In the background the JSST can work on the acutal fix for the issue.

avatar mbabker
mbabker - comment - 21 Jul 2018

What's the status here?

avatar franz-wohlkoenig franz-wohlkoenig - change - 21 Jul 2018
Status Pending Information Required
avatar SniperSister
SniperSister - comment - 1 Aug 2018

@mbabker ready for merge from my side

avatar mbabker mbabker - change - 1 Aug 2018
Status Information Required Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2018-08-01 11:58:38
Closed_By mbabker
avatar mbabker mbabker - close - 1 Aug 2018
avatar mbabker mbabker - merge - 1 Aug 2018
avatar rdeutz
rdeutz - comment - 1 Aug 2018

ATM we are only doing this for staging and not for 4.0-dev?

avatar SniperSister
SniperSister - comment - 1 Aug 2018

yes, J4 will follow!

Add a Comment

Login with GitHub to post a comment