[#20790] - [4..0] Fixing Searchfilter Field in com_finder
- Fixed in Code Base
- 20 Jun 2018
- Medium
- Build: 4.0-dev
- # 20790
- Diff
- Hackwar:j4finder_filter
- Pending Hound Hound is busy reviewing changes... Details
User tests: Successful: Unsuccessful:
Right now the Searchfilter field in the menu item does not work. Instead of that field, a simple text field is loaded. This fixes that. It also removes the Directories Field, which is used nowhere and is basically a copy of the Folderlist field that we have in core.
How to test
- Enable the smart search plugin, index all your content
- Go to the search filters in the backend and create a new filter
- Go to your Smart Search Menu item and see that the field "Search Filters" is just a text input.
- Apply this patch
- See that the Search Filters field now displays a list
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_finder Front End |
In fact I was right
You need to also modify the module xml
<fields name="params" addfieldpath="/administrator/components/com_finder/models/fields">
to
<fields name="params" addfieldprefix="Joomla\Component\Finder\Administrator\Field">
| Labels |
Added:
?
|
||
| Category | Administration com_finder Front End | ⇒ | Administration com_finder Front End Modules |
Fixed.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20790.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20790.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20790.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20790.
| Labels |
Added:
?
|
||
Can you drop a PR to deprecate the unused field in 3.9 branch please
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-06-20 11:00:16 |
| Closed_By | ⇒ | wilsonge |
Don't you need to also modify the module?