User tests: Successful: Unsuccessful:
In all Versions until now, the backend view com_menus/menus has a button "Edit".
In 4.0 the edit button does not exist any more.
It is not self-explaining for novice users that editing the menu itself is made by clicking on the name of the menu type.
Additionally the icon pencil in v4.0 indicates "edit" but does not lead to a form but means "manage the items of this menu".
This PR
Apply the PR, test that the icons go to the respective views
Yes
Status | New | ⇒ | Pending |
Category | ⇒ | Administration com_menus Language & Strings Modules |
In future could you please add before and after images. It really helps
I believe this file is not part of this PR administrator/modules/mod_logged/tmpl/default.php
Labels |
Added:
?
?
|
@brianteeman sorry, this shold be only one small PR for view menus. Unfortnately, old commits are included here. How can I remove them?
Category | Administration com_menus Language & Strings Modules | ⇒ | Administration com_menus Language & Strings |
I believe this file is not part of this PR administrator/modules/mod_logged/tmpl/default.php
I have now force pushed only the changes that should be applied here so the mod_logged change is gone now :)
I've removed the reference to accessibility. This is another subject as @brianteeman said
Just a thought but how about only displaying the Menu Name and thee two icons (edit menu and edit menu items) and not displaying the "unique name". Is there any value to displaying that?
I am not sure you would ever do that in the real world as can be seen by the resulting problem with the select in the menu items dropdown. In your use case I would probably be using the module title as "Information" and the menu name as "information members" etc
You are right. The whole concept with menu names seems to be "old". Them menu name itself appears for example in the menu selection and there it makes problems as I cannot see which menu to select. So indeed it wold be sufficient to require unique names for menus.
Removing the unique name completely is very tempting :) I'll try - but it has impact on some views/models and the database.
The same problem with Categories btw.
Category | Administration com_menus Language & Strings | ⇒ | Administration Language & Strings |
Now it looks like this, following the poposal of @brianteeman
@chmst
Looks like there is now only an .ini diff in this PR.
May I suggest an improvement vs your screencapture?
Something like (as I just modified your screenshot, the columns width is not right):
Move the first icon inside the Title column next to the title to be consistent elsewhere.
Category | Administration Language & Strings | ⇒ | Administration com_menus Language & Strings |
Status | Pending | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-09-10 14:40:41 |
Closed_By | ⇒ | franz-wohlkoenig |
Closed_By | franz-wohlkoenig | ⇒ | joomla-cms-bot |
Set to "closed" on behalf of @franz-wohlkoenig by The JTracker Application at issues.joomla.org/joomla-cms/20787
closed as stated by @chmst at #22112
(Your comment about links is very valid and is something that needs to be addressed but its a global issue and not specific to here)