? ? Pending

User tests: Successful: Unsuccessful:

avatar chmst
chmst
18 Jun 2018

In all Versions until now, the backend view com_menus/menus has a button "Edit".
In 4.0 the edit button does not exist any more.

It is not self-explaining for novice users that editing the menu itself is made by clicking on the name of the menu type.
Additionally the icon pencil in v4.0 indicates "edit" but does not lead to a form but means "manage the items of this menu".
view_menus_before

This PR

  • Changes the edit-icon (pencil) to the list-icon, it goes to the manage items view
  • Adds an edit button (pencil) to the menutype link, it goes to the edit menu view
  • Adds sr-only attributes to the icons
    view_menus_after

Testing instructions

Apply the PR, test that the icons go to the respective views

Documentation Changes Required

Yes

avatar chmst chmst - open - 18 Jun 2018
avatar chmst chmst - change - 18 Jun 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 18 Jun 2018
Category Administration com_menus Language & Strings Modules
avatar chmst chmst - change - 18 Jun 2018
The description was changed
avatar chmst chmst - edited - 18 Jun 2018
avatar brianteeman
brianteeman - comment - 18 Jun 2018

(Your comment about links is very valid and is something that needs to be addressed but its a global issue and not specific to here)

avatar brianteeman
brianteeman - comment - 18 Jun 2018

In future could you please add before and after images. It really helps

avatar chmst chmst - change - 18 Jun 2018
The description was changed
avatar chmst chmst - edited - 18 Jun 2018
avatar brianteeman
brianteeman - comment - 18 Jun 2018

I believe this file is not part of this PR administrator/modules/mod_logged/tmpl/default.php

avatar chmst chmst - change - 18 Jun 2018
Labels Added: ? ?
avatar chmst
chmst - comment - 18 Jun 2018

@brianteeman sorry, this shold be only one small PR for view menus. Unfortnately, old commits are included here. How can I remove them?

avatar joomla-cms-bot joomla-cms-bot - change - 18 Jun 2018
Category Administration com_menus Language & Strings Modules Administration com_menus Language & Strings
avatar zero-24
zero-24 - comment - 18 Jun 2018

I believe this file is not part of this PR administrator/modules/mod_logged/tmpl/default.php

I have now force pushed only the changes that should be applied here so the mod_logged change is gone now :)

avatar chmst
chmst - comment - 18 Jun 2018

Thank you very much, @zero-24

avatar chmst chmst - change - 21 Jun 2018
The description was changed
avatar chmst chmst - edited - 21 Jun 2018
avatar chmst
chmst - comment - 21 Jun 2018

I've removed the reference to accessibility. This is another subject as @brianteeman said


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20787.

avatar brianteeman
brianteeman - comment - 21 Jun 2018

Just a thought but how about only displaying the Menu Name and thee two icons (edit menu and edit menu items) and not displaying the "unique name". Is there any value to displaying that?

avatar chmst
chmst - comment - 21 Jun 2018

I am testing different use cases. So now I have three menus with different ACL. They have the same name but different unique names.
unique-menu-names

Here the unique name is necessary.

avatar brianteeman
brianteeman - comment - 21 Jun 2018

I am not sure you would ever do that in the real world as can be seen by the resulting problem with the select in the menu items dropdown. In your use case I would probably be using the module title as "Information" and the menu name as "information members" etc

avatar chmst
chmst - comment - 21 Jun 2018

You are right. The whole concept with menu names seems to be "old". Them menu name itself appears for example in the menu selection and there it makes problems as I cannot see which menu to select. So indeed it wold be sufficient to require unique names for menus.
menu-select

Removing the unique name completely is very tempting :) I'll try - but it has impact on some views/models and the database.

The same problem with Categories btw.

avatar joomla-cms-bot joomla-cms-bot - change - 21 Jun 2018
Category Administration com_menus Language & Strings Administration Language & Strings
avatar chmst
chmst - comment - 21 Jun 2018

Now it looks like this, following the poposal of @brianteeman
view_menus_new

Against the old view:
view_menus_old

avatar infograf768
infograf768 - comment - 22 Jun 2018

@chmst
Looks like there is now only an .ini diff in this PR.

May I suggest an improvement vs your screencapture?

  1. As we are in the Menu Manager, the first icon should concern the Menu, not the menu items.
  2. It would clarify all if we have a special column with a heading for Menu Items.

Something like (as I just modified your screenshot, the columns width is not right):
chmst2

avatar Quy
Quy - comment - 26 Jun 2018

Move the first icon inside the Title column next to the title to be consistent elsewhere.

avatar joomla-cms-bot joomla-cms-bot - change - 1 Jul 2018
Category Administration Language & Strings Administration com_menus Language & Strings
avatar brianteeman
brianteeman - comment - 10 Aug 2018

@chmst can you please resolve the conflicts and address the issues raised by @Quy and then we can get this tested and merged

avatar franz-wohlkoenig franz-wohlkoenig - change - 10 Sep 2018
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2018-09-10 14:40:41
Closed_By franz-wohlkoenig
avatar joomla-cms-bot joomla-cms-bot - change - 10 Sep 2018
Closed_By franz-wohlkoenig joomla-cms-bot
avatar joomla-cms-bot joomla-cms-bot - close - 10 Sep 2018
avatar joomla-cms-bot
joomla-cms-bot - comment - 10 Sep 2018
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 10 Sep 2018

closed as stated by @chmst at #22112


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20787.

Add a Comment

Login with GitHub to post a comment