[#20782] - [CI] Add code linter for lowest supported PHP version
- Closed
- 23 Jul 2018
- Medium
- Build: staging
- # 20782
We should add code linting to our CI integrations to scan over changed files to ensure the syntax remains compatible with our lowest supported PHP version. It's way too easy to introduce newer version syntax into files that have zero test coverage where the only way to detect issues is going to be thorough reading of diffs or one of the low number of users on old versions raising an issue.
There's already a lint command in build.xml which will scan the full repo, in theory it should be possible to get changed files in a pull request and run php -l on that list of files.
joomla-cms-bot
- | Labels |
Added:
?
|
||
franz-wohlkoenig
- | Category | ⇒ | Unit Tests |
| Status | New | ⇒ | Discussion |
| Status | Discussion | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-07-23 19:08:19 |
| Closed_By | ⇒ | mbabker |
@mbabker there even better way then php -l see this project.
Well aware, I oversee the Joomla compatibility ruleset for that
Then what besides the general problems with CI blocks us from using this project to achieve the purpose described in this issue?
It doesn't support PHPCS 1.x and aside from the work @photodude has been doing there is very little effort in moving the CMS from using the long deprecated PHPCS 1.x releases to PHPCS 2.x or 3.x.
PHP-CS-Fixer is a different tool from PHP_CodeSniffer (commonly acronymed as PHPCS).
But we are one step closer.
We have enough CI related issues without adding to the wishlist.