[#20775] - [4.0] Installer Checks
- Fixed in Code Base
- 19 Jun 2018
- Medium
- Build: 4.0-dev
- # 20775
- Diff
- brianteeman:installer2
- Pending Hound Hound is busy reviewing changes... Details
User tests: Successful: Unsuccessful:
This PR attempts to add error message explanations on the failing pre-install checks
I have also taken the opportunity to rename some of the constants used in the precheck and move them to the correct section.
I am not 100% confident on the technical merit of the messages
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Installation Language & Strings |
| Labels |
Added:
?
?
|
||
@puneet0191 any news?
hey @brianteeman I am not sure what I am missing, I tried testing the PR on my local, I have Json enabled, but I am still getting the pre-installation check JSON Support Message.
I think we have the same problem on System Test Docker Image.
ah ok let me double check - maybe I left some of the testing code in there.
yes - its my fault -sorry to bother you - but at least it proves the tests work
Fixing it now
Thanks
Silly me - I left some changes I had to make to see the errors in the PR. All fixed now and ready for testing
I must say, what a wonderful work with system testing
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-06-19 13:12:14 |
| Closed_By | ⇒ | wilsonge |
Looks good to me! Thanks!
Thanks
For whatever reason system test are failing on this PR, this needs to be fixed before.
/cc @yvesh @puneet0191