? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
14 Jun 2018

the ability to set the site_metadesc and the site_offline are not present in this installer

The language files hd also been removed but they were still referenced in the setup.xml

@dgrammatiko @wilsonge
Don't forget that ftp is still marked todo
and
I wanted to try and check the pre-install screen strings but i couldnt trigger it for testing - any tips

avatar brianteeman brianteeman - open - 14 Jun 2018
avatar brianteeman brianteeman - change - 14 Jun 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 14 Jun 2018
Category Installation
avatar wilsonge
wilsonge - comment - 14 Jun 2018

For the PHP Version incompatible screen bump the PHP Version here to something stupid like PHP 8.0 https://github.com/joomla/joomla-cms/blob/4.0-dev/installation/index.php#L16

For the pre-install screen if I remember rightly you need to set one of the states https://github.com/joomla/joomla-cms/blob/4.0-dev/installation/src/Model/ChecksModel.php#L77 here to be false instead of determining a value

avatar brianteeman
brianteeman - comment - 14 Jun 2018

php version I had done. I was trying that for the pre-install screen but maybe I did something wrong - will try again in the morning - thanks

avatar wilsonge
wilsonge - comment - 14 Jun 2018

Amended link above to point to the 4.0 branch instead of staging branch! Just tested now and changing that line to be false definitely triggers the screen for me

avatar brianteeman
brianteeman - comment - 14 Jun 2018

ok - thanks

avatar brianteeman brianteeman - change - 14 Jun 2018
Labels Added: ?
avatar wilsonge wilsonge - change - 14 Jun 2018
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2018-06-14 22:37:34
Closed_By wilsonge
avatar wilsonge wilsonge - close - 14 Jun 2018
avatar wilsonge wilsonge - merge - 14 Jun 2018
avatar wilsonge
wilsonge - comment - 14 Jun 2018

Merging this one in the mean time! Thanks!

avatar brianteeman
brianteeman - comment - 14 Jun 2018

Thanks

Add a Comment

Login with GitHub to post a comment