? Pending

User tests: Successful: Unsuccessful:

avatar panopt
panopt
12 Jun 2018

About the fix

Without the view=login parameter JRoute can not resolve the Itemid.
So the menu item assigned to 'login' view is not active.

Step to reproduce the issue

  1. Create a menu item for the login page (option=com_users&view=login).

  2. Create an article with :
    Article -> Access level : Registered
    Article -> Properties: "Link not authorized" = "Yes".

  3. Create a menu item for this article :
    Article -> Properties: "Link not authorized" = "Yes". (to be sure)

  4. Click on the menu item (you must not be logged in frontend)

Actual result

You are redirected to the login page but the right menu item is not active.

Expected result

You are redirected to the login page and the right menu item is active.

Additional comments

Seems there is a related hack here:
/com_content/views/article/tmpl/default.php ~line 143

This can also cause problems with third party extensions like sh404sef.

avatar panopt panopt - open - 12 Jun 2018
avatar panopt panopt - change - 12 Jun 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 12 Jun 2018
Category Front End com_content
avatar panopt panopt - change - 12 Jun 2018
The description was changed
avatar panopt panopt - edited - 12 Jun 2018
avatar carlitorweb carlitorweb - test_item - 15 Jun 2018 - Tested successfully
avatar carlitorweb
carlitorweb - comment - 15 Jun 2018

I have tested this item successfully on 01c5d40

I think this is more like JRoute need try to find the default view. Not sure if this behavior is part of JRoute.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20732.

avatar franz-wohlkoenig franz-wohlkoenig - test_item - 16 Jun 2018 - Tested successfully
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 16 Jun 2018

I have tested this item successfully on 01c5d40

Using PR: Click on "Registered Article Menu" send User to Login-Menu.
Without PR: Click on "Registered Article Menu" send User to Home-Menu showing Login-Form.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20732.

avatar franz-wohlkoenig franz-wohlkoenig - change - 16 Jun 2018
Status Pending Ready to Commit
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 16 Jun 2018

Ready to Commit after two successful tests.

avatar infograf768
infograf768 - comment - 16 Jun 2018

I do not have this issue here. I even tested on a multilingual site. Will test with the PR.

avatar infograf768
infograf768 - comment - 16 Jun 2018

the PR does not break it either.

avatar carlitorweb
carlitorweb - comment - 16 Jun 2018

@infograf768 In the last staging, you get this without the PR

video_2018-06-16_114509

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 16 Jun 2018

@infograf768 please have a look: http://wohlkoenig.joomla.com/index.php/author-login?return=aHR0cDovL3dvaGxrb2VuaWcuam9vbWxhLmNvbS9pbmRleC5waHAvMjA3MzI=

Click on Menu "Blog", then click on Menu "20732": You are moved to Menu "Author Login", cause Patch is applied.

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 16 Jun 2018

@infograf768 if you wan't i can revert Patch. Then you got move to Menu "Blog" after click on "20732".

avatar infograf768
infograf768 - comment - 16 Jun 2018

Oh, you mean when there is a menu item to display a registered article. I misunderstood. My fault as I did not read correctly the instructions.
I was testing a ReadMore... Sorry again.

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 16 Jun 2018

@infograf768 so i can revert Test?

avatar infograf768
infograf768 - comment - 16 Jun 2018

All is fine. I had not posted a negative test. :)

avatar mbabker mbabker - change - 18 Jun 2018
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2018-06-18 02:48:08
Closed_By mbabker
Labels Added: ?
avatar mbabker mbabker - close - 18 Jun 2018
avatar mbabker mbabker - merge - 18 Jun 2018
avatar panopt
panopt - comment - 19 Jun 2018

Thank you very much for the tests and comments.

Add a Comment

Login with GitHub to post a comment