? ? ? Pending

User tests: Successful: Unsuccessful:

avatar chmst
chmst
12 Jun 2018

The label "menu type" is misleading. "type" is a general concept, here a unique name is required. It would be great if the description could be restored. At least the label should make clear that this name must be unique in the whole system.

Test: code inspection

avatar chmst chmst - open - 12 Jun 2018
avatar chmst chmst - change - 12 Jun 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 12 Jun 2018
Category Administration Language & Strings
avatar chmst chmst - change - 12 Jun 2018
The description was changed
avatar chmst chmst - edited - 12 Jun 2018
avatar chmst chmst - change - 12 Jun 2018
Labels Added: ? ?
avatar brianteeman
brianteeman - comment - 12 Jun 2018

I never understood what this meant anyway

avatar brianteeman brianteeman - test_item - 12 Jun 2018 - Tested successfully
avatar brianteeman
brianteeman - comment - 12 Jun 2018

I have tested this item successfully on 2b7ef8d


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20726.

avatar chmst
chmst - comment - 12 Jun 2018

The whole handling is contrary of UX. This name is like a alias name - maybe better to use it like in content or elsewhere.

avatar brianteeman
brianteeman - comment - 12 Jun 2018

I honestly have no idea why we have it or what it is for. I am guessing it is an internal name - if so then there is no need to expose it at all and it can just be autogenerated like the alias

avatar Wang-Yu-Chao Wang-Yu-Chao - test_item - 12 Jun 2018 - Tested successfully
avatar Wang-Yu-Chao
Wang-Yu-Chao - comment - 12 Jun 2018

I have tested this item successfully on 2b7ef8d


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20726.

The "Menu Type" label is replaced by "Unique Name" in the "Title" column.
image

avatar Quy Quy - change - 12 Jun 2018
Title
Rename label for menu type
[4.0] Rename label for menu type
avatar joomla-cms-bot joomla-cms-bot - edited - 12 Jun 2018
avatar Quy
Quy - comment - 12 Jun 2018

The description in v3 refers it as system name. Would System Name be better?

avatar franz-wohlkoenig franz-wohlkoenig - change - 12 Jun 2018
Status Pending Ready to Commit
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 12 Jun 2018

Ready to Commit after two successful tests.

avatar brianteeman
brianteeman - comment - 12 Jun 2018

@Quy thi is an improvement as the old name didnt imply it must be unique

avatar wilsonge wilsonge - change - 13 Jun 2018
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2018-06-13 12:00:31
Closed_By wilsonge
Labels Added: ?
avatar wilsonge wilsonge - close - 13 Jun 2018
avatar wilsonge wilsonge - merge - 13 Jun 2018
avatar Quy
Quy - comment - 1 Jul 2018

The search box has tooltip Search in title and menu type. that needs to be updated.

avatar chmst
chmst - comment - 1 Jul 2018

I am not really happy with this solution.
For users ist is important to know that this is a unique name and that it is used only by the system.
The term "menutype" is used many times especially in com_associations, so it has a meaning for developers. Why not add again the description for users?
menutype-description

Then in #20787 (review) we could add the menutype like the alias in com_content/articles.

Add a Comment

Login with GitHub to post a comment