? Pending

User tests: Successful: Unsuccessful:

avatar laoneo
laoneo
11 Jun 2018

JAdapter does have it's own class loading and file path lookup logic. With the introduction of a DI container which can manage objects this becomes obsolete.

This pr deprecates the classes.

avatar laoneo laoneo - open - 11 Jun 2018
avatar laoneo laoneo - change - 11 Jun 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 11 Jun 2018
Category Libraries
avatar carlitorweb carlitorweb - test_item - 15 Jun 2018 - Tested successfully
avatar carlitorweb
carlitorweb - comment - 15 Jun 2018

I have tested this item successfully on ee5b18a


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20714.

avatar carlitorweb
carlitorweb - comment - 15 Jun 2018

@laoneo i think here then we need put something like: As of 4.0, this class will no longer extend from JAdapter

class Installer extends \JAdapter

avatar mbabker
mbabker - comment - 15 Jun 2018

That type of comment is only needed when you're deprecating the class inheritance (i.e. places we broke the inheritance from JObject). You don't need to explicitly say "as of X class will no longer extend Y" when the parent class is being completely removed, that should be implied.

avatar carlitorweb
carlitorweb - comment - 15 Jun 2018

Roger that.

avatar ReLater ReLater - test_item - 16 Jun 2018 - Tested successfully
avatar ReLater
ReLater - comment - 16 Jun 2018

I have tested this item successfully on ee5b18a


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20714.

avatar Quy Quy - change - 16 Jun 2018
Status Pending Ready to Commit
avatar Quy
Quy - comment - 16 Jun 2018

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20714.

avatar mbabker mbabker - change - 18 Jun 2018
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2018-06-18 02:52:07
Closed_By mbabker
Labels Added: ?
avatar mbabker mbabker - close - 18 Jun 2018
avatar mbabker mbabker - merge - 18 Jun 2018

Add a Comment

Login with GitHub to post a comment