[#20704] - [4.0] Migrate com_menus to services
- Fixed in Code Base
- 20 Jun 2018
- Medium
- Build: 4.0-dev
- # 20704
- Diff
- Digital-Peak:j4/service/menus
- Pending Hound Hound is busy reviewing changes... Details
User tests: Successful: Unsuccessful:
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_menus Modules Front End Libraries |
| Labels |
Added:
?
|
||
| Category | Administration com_menus Modules Front End Libraries | ⇒ | Administration com_menus Modules Front End com_modules Libraries |
Looks also like we still have a call to MenusHtml line 248 of /administrator/components/com_menus/tmpl/items/default.php
it should be
<?php echo JHtml::_('menus.association', $item->id); ?>
Can you please update the since tags to deploy Version?
@infograf768 fixed the issues.
@laoneo
git apply still does not work with this PR.
As it is quite a job to apply this patch with eclipse (it does not rename and move files around and does not create new folders), could you give a link to your branch for us to download, install and test? I could not find the Digital-Peak:j4/service/menus branch.
I do not have the errors I remarked before. Menu items associations look like working fine too.
So can we mark it as successful?
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20704.
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-06-20 16:26:54 |
| Closed_By | ⇒ | wilsonge |
Nice one! Thanks :)
Very hard to test this as git apply does not work with it.
After trying some stuff (renaming and moving some files, I do get
`0 Class 'Joomla\Component\Menus\Administrator\Helper\JTable' not found' when selecting menu items associations in com_associations
Not sure this is related to the PR as I may have been wrong in applying the patch