[#20693] - [4.0] Introduce category factory
- Fixed in Code Base
- 20 Sep 2018
- Medium
- Build: 4.0-dev
- # 20693
- Diff
- Digital-Peak:j4/category/factory
User tests: Successful: Unsuccessful:
As discussed on skype, moves the category instance creation code into a factory.
I'v also extended it with a new CategoryInterface class so we do not have to deal with the implementation class directly.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_content Front End Libraries |
| Labels |
Added:
?
|
||
| Category | Administration com_content Front End Libraries | ⇒ | Administration com_banners com_content Front End Libraries |
| Category | Administration com_content Front End Libraries com_banners | ⇒ | Administration com_banners com_content com_fields Front End Libraries |
I have tested this item
This PR here does not break more than is already broken (specially when concerning multilang routing in frontend (info-block).
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20693.
I don't really want to name this CategoriesInterface. The whole category system is a tree implementation, which is why I implemented a node interface here: #21327 I don't know how to name it in the tree-object-sense, but maybe use something that more aligns with tree terminology, instead of focusing heavily on the categories stuff. In an ideal world, JMenu would implement the same interface and menu items become a NodeInterface object, too.
I agree for the tree, but the object which returns the tree is category related. So it makes sense to name it CategoryInterface. The implementation class should probably being renamed.
| Category | Administration com_content Front End Libraries com_banners com_fields | ⇒ | Administration com_banners com_content com_fields Libraries |
| Category | Administration com_content Libraries com_banners com_fields | ⇒ | Administration com_banners com_categories com_content com_fields com_tags Libraries |
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-09-20 06:01:22 |
| Closed_By | ⇒ | laoneo |
I know it's annoyingly retrospective. But this looks good to me.
I need to get this one merged to finish the service conversion of com_contact, com_newsfeeds and com_categories.