Feeling Lucky
?
[#20673] - Clean up code in JTable::store()
- Closed
- 25 Mar 2022
- Medium
- Build: staging
- # 20673
- Diff
- csthomas:improve_code_style
- Success Hound No violations found. Woof! Details
- Success continuous-integration/drone/pr the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
User tests: Successful: Unsuccessful:
Summary of Changes
Improve code style.
- Replace:
if (...)
{
return false;
}
else
{
// ...
}by
if (...)
{
return false;
}
// ...- Remove lines below
$asset->loadByName($name);because it does not set error if asset does not exist. - A few simple changes to improve the legibility of the code.
Testing Instructions
Php units passes.
Code review.
I suggest you do a review by ignoring the white spaces https://github.com/joomla/joomla-cms/pull/20673/files?w=1
Expected result
Works as before.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Labels |
Added:
?
|
||
laoneo
- | Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-03-25 16:13:04 |
| Closed_By | ⇒ | laoneo | |
| Labels |
Added:
?
Removed: ? ? |
||
Done that please tell anything more