Success

User tests: Successful: Unsuccessful:

avatar AshanFernando
AshanFernando
24 Sep 2013

clear when moving from tab view to another view so that when coming back it will open with the default tab

avatar AshanFernando AshanFernando - open - 24 Sep 2013
avatar brunobatista
brunobatista - comment - 24 Sep 2013

:+1:

avatar beat
beat - comment - 9 Oct 2013

Good thing! Does that also fix the regression that when you first time go to a new view that NO tab is selected at all ?

avatar AshanFernando
AshanFernando - comment - 10 Oct 2013

@beat I randomly tested in several sections in the CMS (options, module manager, articles & etc.) but I couldn't find "NO" tab is selected at all situation when going there for the first time.

avatar wilsonge
wilsonge - comment - 10 Oct 2013

I definately can. Clean master install with sample data. Go and edit an item and there is no active tab

avatar brianteeman
brianteeman - comment - 10 Oct 2013

there is an active tab it just isnt styled as if it is. seems to be fixed with this pr

avatar wilsonge
wilsonge - comment - 10 Oct 2013

image

This is without the pull request. But there don't appear to be any data state active or class active's present

Also as this PR is only editing the js and it's not changing the active tab class - I can't see how it will fix the issue. Will test it in a bit tho to confirm my theory though!

avatar elinw elinw - close - 11 Oct 2013
avatar garyamort garyamort - reference | - 2 Dec 13

Add a Comment

Login with GitHub to post a comment