[#20664] - Display 404 page when tracking clicks of a non-existing banner
- Fixed in Code Base
- 12 Jun 2018
- Medium
- Build: staging
- # 20664
- Diff
- Quy:patch-1
User tests: Successful: Unsuccessful:
Pull Request for Issue #20325.
Summary of Changes
When tracking clicks of a deleted/non existent banner ID, the redirect URL is http:// which causes browser error. This PR checks that the banner ID is valid and if not, display a 404 page.
Testing Instructions
On the front end, enter the following URL index.php/component/banners/click/123
Expected result
Display a 404 page
Actual result
Error message generated by the browser regarding broken contents. The return HTTP status is 303 with header Location: http://
In PHP error log:
PHP Notice: Trying to get property 'track_clicks' of non-object in \components\com_banners\models\banner.php on line 61
PHP Notice: Trying to get property 'clickurl' of non-object in \components\com_banners\models\banner.php on line 197
Documentation Changes Required
none
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End com_banners |
| Title |
|
||||||
| Title |
|
||||||
@NormanMalessa please mark your Test as successfully:
- open Issue Tracker
- Login with your github-Account
- Click on blue "Test this"-Button above Authors-Picture
- mark your Test as successfully
- hit "submit test result"
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20664.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20664.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20664.
mbabker
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-06-12 22:43:57 |
| Closed_By | ⇒ | mbabker | |
| Labels |
Added:
?
?
|
||
Verified that it works👍 , have no clue why appveyor build fails