[#20646] - [3.9] Make sure the extension install works as expected
- Fixed in Code Base
- 18 Jun 2018
- Medium
- Build: 3.9-dev
- # 20646
- Diff
- zero-24:fix39installerchecksumagain
User tests: Successful: Unsuccessful:
Moved from #20330
Summary of Changes
Only show a message when the verification fails (request by @mbabker )
Remove the check at install time.
Make sure we are using the correct update object and don't do some magic with passing the update xml.
Testing Instructions
- Install 3.9-dev https://developer.joomla.org/nightlies/Joomla_3.9.0-dev-Development-Full_Package.zip
- Install any outdated extension that do not support hashes yet (well all 3rd party tools)
- notice the message saying that there is no hash provided
- install the update
- notice the message saying that there is no hash provided
- apply this patch
- redo the steps above
- notice that there is no message at all.
- install com_patchtester
- notice there is no message
- apply the update to the latest com_patchtester
- notice there is no message at all. (even as they use hashes)
Expected result
Only show a message when the verification fails (request by @mbabker )
Remove the check at install time.
Make sure we are using the correct update object and don't do some magic with passing the update xml.
Documentation Changes Required
None.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_installer Language & Strings Libraries |
| Labels |
Added:
?
?
|
||
Why Remove the check at install time. ?
Why Remove the check at install time. ?
We are not enforcing checksum validation in 3.x. Actually requiring it in any form is too disruptive and B/C breaking. So we're making the changes needed to have the API and feature support in place without actually turning it on.
yes i know that, but as it is Only show a message when the verification fails
why not let people start thinking about it ?
It'll create more confusion if we start showing validation succeed/failed (or checksums missing) out of the blue, especially without actually changing the code behavior to do something different on the fail state.
ok i can live with it
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20646.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20646.
| Status | Pending | ⇒ | Ready to Commit |
Ready to Commit after two successful tests.
Thanks all for Tests.
| Labels |
Added:
?
|
||
The latest commit just update the branch and fixed the drone issue without changing any active coding. so no re testes required.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-06-18 02:52:38 |
| Closed_By | ⇒ | mbabker |
I have tested this item✅ successfully on 66f3eb0
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20646.