[#20644] - [3.9] Make sure the update hash checker produces the correct result
- Fixed in Code Base
- 18 Jun 2018
- Medium
- Build: 3.9-dev
- # 20644
- Diff
- zero-24:fix39updateragain
User tests: Successful: Unsuccessful:
Moved from #20329
Summary of Changes
- Only show a message when the verification fails (request by @mbabker )
- Handle the verification locally in com_joomlaupdate so we don't depend on the other method to be up-to-date. (like releasing a standalone version)
- Throw something in the log when the verification fails.
- Make sure we are using the correct update object and don't do some magic with passing the update xml.
Testing Instructions
First Case
- install 3.9-dev https://developer.joomla.org/nightlies/Joomla_3.9.0-dev-Development-Full_Package.zip
- Apply this update server: https://www.jah-tz.de/downloads/core/nightlies/next_minor_list.xml
- install the update
- notice there is a warning claiming that the hash was not set. ;)
Seccond Case
- Install 3.9-dev with this changes: https://github.com/zero-24/joomla-cms/archive/fix39updateragain.zip
- Apply this update server: https://www.jah-tz.de/downloads/core/nightlies/next_minor_list.xml
- install the update
- notice there is no warning
Expected result
Make sure the update works without any kind of warning
Actual result
Well the update works but throws a warning as the url is not passed.
Documentation Changes Required
None.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_joomlaupdate |
Yes.
Tried "Second case" with fix39updateragain.zip and see a single message
Warning: File Checksum Failed
Tell me please if that's a successful test for this pr because the checksum just has changed since last nightly build.
"First Case" messages yesterday were:
On the other hand. Shouldn't the update stop if checksum is wrong? Or is that not part of this pr?
On the other hand. Shouldn't the update stop if checksum is wrong? Or is that not part of this pr?
We are not going to enforce this in 3.x but in 4.0 as per note in the inline comment ;)
"First Case" messages yesterday were:
This seams to be still the old code as the message you got was removed in this patch.
Please remember that when you update to the nightly the patch applied here get reverted ;)
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20644.
| Labels |
Added:
?
|
||
| Category | Administration com_joomlaupdate | ⇒ | Administration com_joomlaupdate Language & Strings |
| Labels |
Added:
?
|
||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20644.
EDIT: FORGET THIS COMMENT! Everything fine ;-)
Maybe I'm just confused and everything is OK.
I still have a message during update (see image) following the steps of "Second Case" of instructions. Update via Live Update > Reinstall Joomla Core Files (https://developer.joomla.org/nightlies/Joomla_3.9.0-dev-Development-Update_Package.zip)
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20644.
Yeah, just confused (happy). Everything Ok after code review.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20644.
mbabker
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-06-18 02:53:49 |
| Closed_By | ⇒ | mbabker | |
| Labels |
Added:
?
|
||
throws an "404 Not found".
To be replaced with https://github.com/zero-24/joomla-cms/archive/fix39updateragain.zip ?