? ? Pending

User tests: Successful: Unsuccessful:

avatar laoneo
laoneo
1 Jun 2018

As discussed last year at JDayUK, it would be nice to have some model interfaces (probably also for controller and views on some point). This pr adds the following new interfaces for the existing MVC models (except the admin model):

  • ModelInterface
  • StateModelInterface
  • DatabaseModelInterface
  • ListModelInterface
  • ItemModelInterface

Backwards compatibility

The ItemModel requires now a getItem function. This function needs a $pk argument which is defaulted to null.

More changes

The state code of the BaseDatabaseModel got moved into a new subclass StateModel and the legacy getInstance stuff into a legacy trait. So we have stuff a bit better separated.

avatar laoneo laoneo - open - 1 Jun 2018
avatar laoneo laoneo - change - 1 Jun 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 1 Jun 2018
Category Administration com_content com_contenthistory Libraries
avatar laoneo laoneo - change - 2 Jun 2018
Labels Added: ?
74e7787 2 Jun 2018 avatar laoneo CS
1226bd4 2 Jun 2018 avatar laoneo CS
avatar laoneo
laoneo - comment - 3 Jun 2018

Added a FormBehaviorTrait to remove the redundant code between the FormModel and ListModel.

a6d9ec9 3 Jun 2018 avatar laoneo CS
avatar wilsonge
wilsonge - comment - 22 Jul 2018

I'm holding on merging this for now with all the entity work going on. I don't want to make a semi-major change like this if we can get the entity stuff into 4.0 - if we don't have time to get it in then clearly this is fine and can be merged

avatar laoneo
laoneo - comment - 22 Jul 2018

I do not understand why the entities work does block this one as it is basically a new branch of classes starting from the BaseModel or not?

avatar laoneo
laoneo - comment - 3 Sep 2018

As GsoC is finished, what's the state of the Entities project?

avatar laoneo
laoneo - comment - 13 Sep 2018

@wilsonge how should we move on here?

avatar laoneo laoneo - change - 23 Nov 2018
Labels Added: ?
avatar wilsonge
wilsonge - comment - 5 Jan 2019

OK Now i've compromised with webservices to use legacy MVC time to resurrect this :)

avatar wilsonge
wilsonge - comment - 7 Jan 2019

@zero-24 drone please

avatar zero-24
zero-24 - comment - 7 Jan 2019
avatar wilsonge
wilsonge - comment - 8 Jan 2019

@zero-24 sorry can you do your magic again please

avatar zero-24
zero-24 - comment - 8 Jan 2019
avatar zero-24
zero-24 - comment - 8 Jan 2019

rips is happy now

avatar wilsonge wilsonge - change - 8 Jan 2019
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-01-08 22:54:58
Closed_By wilsonge
avatar wilsonge wilsonge - close - 8 Jan 2019
avatar wilsonge wilsonge - merge - 8 Jan 2019
avatar wilsonge
wilsonge - comment - 8 Jan 2019

Thankyou for being patient with this! :)

Add a Comment

Login with GitHub to post a comment