[#20630] - Remove redundant files
- Closed
- 10 Feb 2019
- Medium
- Build: staging
- # 20630
- Diff
- PhilETaylor:RemoveRedundantFiles
User tests: Successful: Unsuccessful:
Forked from #20616
Summary of Changes
Remove files that Joomla 3.8.8 doesnt actually use, that contain minor security issues, and that generate PHP warnings when actually loaded as a template. They look abandoned (unless someone can prove to me they are not, and are actually used somewhere)
Testing Instructions
Apply PR, Fully test com_media with doc, folder and videos in your media folders.
Expected result
Nothing breaks.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_media |
Truthfully I'm not fully concerned about it. Since introducing https://github.com/joomla/joomla-cms/blob/staging/build/deleted_file_check.php to the repo it's been a habit to run that when prepping each release. So even if not included in this PR, at worst it'll be included in the "prep RC" commit.
as long as that "habit" has been added to the documentation for creating a release ;)
We have documentation for critical workflows and procedures!?
Relevant history
#13519 (comment)
So it would be good to add to the script.php list too then right? I can do that
| Labels |
Added:
?
|
||
| Category | Administration com_media | ⇒ | Administration com_admin com_media |
No idea why this has not been merged in over a year, but now it reports a conflict on the files it tries to delete - even though those files still exist https://github.com/joomla/joomla-cms/tree/staging/administrator/components/com_media/views/medialist/tmpl
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-02-10 21:36:21 |
| Closed_By | ⇒ | PhilETaylor |
Did not test if they are used or not, but don't they have to be added in script.php https://github.com/joomla/joomla-cms/blob/staging/administrator/components/com_admin/script.php#L430 ?