? Pending

User tests: Successful: Unsuccessful:

avatar laoneo
laoneo
29 May 2018

Pull Request for Issue #20481, #20356 and #20484.

#20619 needs to be merged first!!

Moves com_config to the service based extension setup.

See #20217 for details.

avatar laoneo laoneo - open - 29 May 2018
avatar laoneo laoneo - change - 29 May 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 29 May 2018
Category Administration com_config com_templates Front End Libraries
avatar brianteeman
brianteeman - comment - 29 May 2018

because #20619 needs to be merged first according to the test instructions this cannot be tested with com_patchtester

avatar laoneo laoneo - change - 29 May 2018
The description was changed
avatar laoneo laoneo - edited - 29 May 2018
avatar laoneo
laoneo - comment - 30 May 2018

Why do you can't test it with patch tester? Is there an error?

avatar infograf768
infograf768 - comment - 30 May 2018

Why do you can't test it with patch tester? Is there an error?

afaik patchtester can't move files around.

avatar laoneo
laoneo - comment - 30 May 2018

Ok, here is a link to the branch where you can download joomla directly https://github.com/Digital-Peak/joomla-cms/archive/j4/services/config.zip

avatar brianteeman
brianteeman - comment - 30 May 2018

it cant be tested with patchtester as you say it needs #20619 installed first and as this also touches one of the same files patchtester prevents this one being applied

avatar laoneo
laoneo - comment - 30 May 2018

#20619 is included in this pr as well, otherwise I couldn't develop it either

avatar brianteeman
brianteeman - comment - 30 May 2018

ah - then your message was confusing

avatar brianteeman
brianteeman - comment - 30 May 2018

I have tested this item successfully on 13bf706

Tested the admin and works
Tested the site config and template config from front end and previous issues are resolved by this pr


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20620.

avatar brianteeman brianteeman - test_item - 30 May 2018 - Tested successfully
avatar laoneo laoneo - change - 31 May 2018
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 31 May 2018
Category Administration com_config com_templates Front End Libraries Administration com_config com_templates Front End
c37e26a 31 May 2018 avatar laoneo cs
avatar wilsonge wilsonge - close - 4 Jun 2018
avatar wilsonge wilsonge - merge - 4 Jun 2018
avatar wilsonge wilsonge - change - 4 Jun 2018
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2018-06-04 21:39:22
Closed_By wilsonge

Add a Comment

Login with GitHub to post a comment