Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
29 May 2018

As reported #13678

On a default multilingual install with the language switcher and search module published in the default protostar positions the styling is not great. This simple pr resolves that by removing the extra styling. Out of the box the joomla template and styling should look good

before

chrome_2018-05-29_09-52-08

after

chrome_2018-05-29_09-44-38

avatar brianteeman brianteeman - open - 29 May 2018
avatar brianteeman brianteeman - change - 29 May 2018
Status New Pending
avatar infograf768
infograf768 - comment - 29 May 2018

Ths is not B/C and will change the display when the switcher is placed in a column.
Example:
before:
screen shot 2018-05-29 at 11 09 08
after
screen shot 2018-05-29 at 11 10 03

avatar ciar4n
ciar4n - comment - 29 May 2018

I'd class this as a B/C break as you are removing the reset for browser defaults on a UL. 3PD templates may need to add back this CSS if not already present within template styling.

If needed I would add padding/margin to the Protostar template CSS instead.

avatar brianteeman
brianteeman - comment - 29 May 2018

css is not part of the b/c promise

avatar ciar4n
ciar4n - comment - 29 May 2018

In that case delete media/mod_languages/css/template.css. There is no point of having any CSS that template developers can not rely on.

avatar infograf768
infograf768 - comment - 29 May 2018

css is not part of the b/c promise

For a totally new release, maybe (4.0 for example), but certainly not for a current release line.

avatar brianteeman
brianteeman - comment - 29 May 2018

I am going by the documented policy and not simply inventing something

https://developer.joomla.org/development-strategy.html#backward_compatibility

avatar franz-wohlkoenig franz-wohlkoenig - change - 29 May 2018
Category Modules
avatar mbabker
mbabker - comment - 29 May 2018

It's not part of the B/C promise but if it's going to be disruptive, as is the case here, then we need a different solution.

Seems like that's going to be adding more CSS to account for when the language switcher is inside the .header-search div in the Protostar template.

avatar infograf768
infograf768 - comment - 29 May 2018

Seems like that's going to be adding more CSS to account for when the language switcher is inside the .header-search div in the Protostar template.

good idea. I guess these should be in protostar template css.

avatar infograf768
infograf768 - comment - 30 May 2018

We just need this in protostar imho:

.header-search .mod-languages ul {
	margin:0 0 5px 0;
}
avatar brianteeman brianteeman - change - 12 Jun 2018
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2018-06-12 11:56:39
Closed_By brianteeman
avatar brianteeman brianteeman - close - 12 Jun 2018
avatar joomla-cms-bot joomla-cms-bot - change - 12 Jun 2018
Category Modules

Add a Comment

Login with GitHub to post a comment