? Pending

User tests: Successful: Unsuccessful:

avatar SharkyKZ
SharkyKZ
28 May 2018

Pull Request for Issue #20600.

Summary of Changes

This corrects image display in Tagged Items view when multiple item types are displayed and one of the types is Category.

Testing Instructions

Apply a tag to some articles and categories.
Add images to articles and categories.
Create Tagged Items menu item.
Enable 'Item Image' under 'Item Options' in menu item.

Expected result

Images of all tagged items displayed correctly.

Actual result

Two possible results depending on the type of the first item in the list. If the first item is an article, category images are not shown. If the first item is a category, article images are not shown and notice appears:

Notice: Undefined property: stdClass::$image in /public_html/components/com_tags/views/tag/view.html.php on line 166

Documentation Changes Required

No.

avatar SharkyKZ SharkyKZ - open - 28 May 2018
avatar SharkyKZ SharkyKZ - change - 28 May 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 28 May 2018
Category com_tags Front End
avatar Quy
Quy - comment - 29 May 2018

I have tested this item successfully on e31a060


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20601.

avatar Quy Quy - test_item - 29 May 2018 - Tested successfully
avatar franz-wohlkoenig franz-wohlkoenig - test_item - 16 Jun 2018 - Tested successfully
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 16 Jun 2018

I have tested this item successfully on e31a060

Thanks for PR; Tags needs Love.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20601.

avatar franz-wohlkoenig franz-wohlkoenig - change - 16 Jun 2018
Status Pending Ready to Commit
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 16 Jun 2018

Ready to Commit after two successful tests.

avatar mbabker mbabker - change - 18 Jun 2018
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2018-06-18 02:55:09
Closed_By mbabker
Labels Added: ?
avatar mbabker mbabker - close - 18 Jun 2018
avatar mbabker mbabker - merge - 18 Jun 2018

Add a Comment

Login with GitHub to post a comment