Feeling Lucky
?
?
[#20590] - Fix stale session data wrongly overriding configuration file when editing global configuration
- Fixed in Code Base
- 12 Jun 2018
- Medium
- Build: staging
- # 20590
- Diff
- ggppdk:patch-61
User tests: Successful: Unsuccessful:
Pull Request for Issue #20588
Stale session data should not override configuration file when editing global configuration
Make it consistent with all other controllers
Summary of Changes
- Only save data (of global configuration) into session when an error occurs
- validation error
- saving error
- Clear session data on successful execution of the task
Testing Instructions
- Load global config and set debug to ON and save and close
- Manually edit $debug = '0'; in /configuration.php, thus setting debug to OFF
- Click to re-edit global config
Expected result
The DEBUG setting is shown as OFF
Actual result
The DEBUG setting is shown as ON
Documentation Changes Required
None
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_config |
| Labels |
Added:
?
|
||
Quy
- comment
- 8 Jun 2018
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20590.
| Status | Pending | ⇒ | Ready to Commit |
Quy
- comment
- 8 Jun 2018
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20590.
mbabker
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-06-12 22:45:25 |
| Closed_By | ⇒ | mbabker | |
| Labels |
Added:
?
|
||
I have tested this item✅ successfully on 72ad71b
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20590.