?
avatar PhilETaylor
PhilETaylor
27 May 2018

Steps to reproduce the issue

Install Joomla 3.8.8
Go to admin -> Global Configuration -> as a test enable DEBUG = YES - then save,

LEAVE THE GLOBAL CONFIG PAGE OPEN (http://example.com/administrator/index.php?option=com_config)

Manually edit $debug = '0'; in /configuration.php, therefore setting debug to off

return to the Joomla admin and simply refresh the page (http://example.com/administrator/index.php?option=com_config)

Expected result

That the change on the file system is reflected in the interface

Actual result

Debug is still shown as on.
The config is loaded from the session, instead of from configuration.php

System information (as much as possible)

Joomla 3.8.8
Google Chrome

avatar PhilETaylor PhilETaylor - open - 27 May 2018
avatar joomla-cms-bot joomla-cms-bot - change - 27 May 2018
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 27 May 2018
avatar PhilETaylor PhilETaylor - change - 27 May 2018
The description was changed
avatar PhilETaylor PhilETaylor - edited - 27 May 2018
avatar franz-wohlkoenig franz-wohlkoenig - change - 27 May 2018
Status New Discussion
avatar franz-wohlkoenig franz-wohlkoenig - change - 27 May 2018
Category com_config
avatar dgrammatiko
dgrammatiko - comment - 27 May 2018

Log out and log in again should update the values

avatar PhilETaylor
PhilETaylor - comment - 27 May 2018

Thats not the point. The page should read from configuration.php and not from saved session values should they differ.

avatar dgrammatiko
dgrammatiko - comment - 27 May 2018

I think it’s done this way for performance, but I guess the edit page should always fetch from the file, so I agree here

avatar dgrammatiko
dgrammatiko - comment - 27 May 2018

Flipping the arrays here

should do that, I do t know if there are bad effects doing it though

avatar ggppdk
ggppdk - comment - 28 May 2018

That merge order seems correct

administrator/components/com_config/controller/application/save.php

is different than other controllers it always adds data into session unlike all other controllers that only add them on

validation error
save error

Also it does not seem to clear them on successful save

avatar joomla-cms-bot joomla-cms-bot - change - 28 May 2018
Status Discussion Closed
Closed_Date 0000-00-00 00:00:00 2018-05-28 05:11:58
Closed_By joomla-cms-bot
avatar franz-wohlkoenig franz-wohlkoenig - change - 28 May 2018
Closed_By joomla-cms-bot franz-wohlkoenig
avatar joomla-cms-bot joomla-cms-bot - close - 28 May 2018
avatar joomla-cms-bot
joomla-cms-bot - comment - 28 May 2018
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 28 May 2018

closed as having Pull Request #20590

Add a Comment

Login with GitHub to post a comment