Joomla! Issue Tracker | Joomla! CMS #20584 - Change spacer's tooltip from tooltip to popover

? ? ?

Pending

User tests: Successful: Unsuccessful:

Quy
26 May 2018

Pull Request for Issue #19604 .

Summary of Changes

Change spacer's tooltip from tooltip to popover to match the other form fields.

Testing Instructions

Edit file \administrator\components\com_content\models\forms\article.xml
Change line 847 from:

		<field
			name="spacer1"
			type="spacer"
			hr="true"
		/>

to:

		<field
			name="spacer1"
			type="spacer"
			label="Label"
			description="This is a description"
		/>

Expected result

Tooltip as popover

Actual result

Tooltip as tooltip

Documentation Changes Required

none

bffb7dd 26 May 2018

Change spacer's tooltip from tooltip to popover

Quy - open - 26 May 2018

Quy - change - 26 May 2018

Status

New

⇒

Pending

joomla-cms-bot - change - 26 May 2018

-------BEFORE--------

--------AFTER--------

carlitorweb - test_item - 7 Jun 2018 - Tested successfully

carlitorweb - comment - 7 Jun 2018

I have tested this item ✅ successfully on bffb7dd

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20584.}

franz-wohlkoenig - alter_testresult - 27 Aug 2018 - infograf768: Tested successfully

franz-wohlkoenig - change - 27 Aug 2018

Status

Pending

⇒

Ready to Commit

SharkyKZ - comment - 20 Nov 2018

RTC?

infograf768 - comment - 20 Nov 2018

Relaunched Travis

infograf768 - comment - 20 Nov 2018

This PR is now useless. popovers have been implemented since.
Closing.

infograf768 - change - 20 Nov 2018

Status	Ready to Commit	⇒	Closed
Closed_Date	0000-00-00 00:00:00	⇒	2018-11-20 09:56:16
Closed_By		⇒	infograf768
Labels	Added: ? ?

infograf768 - close - 20 Nov 2018

SharkyKZ - comment - 20 Nov 2018

This PR is fine. Spacer does not have popovers in current staging.

infograf768 - comment - 20 Nov 2018

reopening, but we have issues with tests in Travis.

SharkyKZ - comment - 20 Nov 2018

Need to update test.

joomla-cms/tests/unit/suites/libraries/joomla/form/fields/JFormFieldSpacerTest.php

Lines 121 to 123 in bffb7dd

    
           		$equals = '<span class="spacer"><span class="before"></span><span>' . 
        
           			'<label id="spacer-lbl" class="hasTooltip" title="&lt;strong&gt;spacer&lt;/strong&gt;">spacer</label></span>' . 
        
           			'<span class="after"></span></span>';

infograf768 - comment - 20 Nov 2018

@Quy
Can you modify the test file?

f13565d 21 Nov 2018

Update test

Quy - change - 21 Nov 2018

Labels

Removed: ?

joomla-cms-bot - change - 21 Nov 2018

Category

Libraries

⇒

Libraries Unit Tests

Quy - change - 25 Nov 2018

Labels

Added: ?

40d0517 25 Nov 2018

Update tests/unit/suites/libraries/joomla/form/fields/JFormFieldSpacerTest.php

SharkyKZ - comment - 26 Nov 2018

I have tested this item ✅ successfully on 40d0517

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20584.}

SharkyKZ - test_item - 26 Nov 2018 - Tested successfully

SharkyKZ - comment - 26 Nov 2018

This issue is still closed on the Issue Tracker.

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20584.}

infograf768 - change - 26 Nov 2018

Status	Closed	⇒	Pending
Closed_Date	2018-11-20 09:56:16	⇒
Closed_By	infograf768	⇒
Labels

infograf768 - comment - 26 Nov 2018

Reopened as pending on Issues Tracker and relaunched Drone.

infograf768 - comment - 26 Nov 2018

I have tested this item ✅ successfully on 40d0517

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20584.}

infograf768 - test_item - 26 Nov 2018 - Tested successfully

infograf768 - change - 26 Nov 2018

Status

Pending

⇒

Ready to Commit

infograf768 - comment - 26 Nov 2018

RTC

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20584.}

infograf768 - comment - 26 Nov 2018

@mbabker
I guess this can go in stable as totally B/C

mbabker - change - 1 Dec 2018

Status	Ready to Commit	⇒	Fixed in Code Base
Closed_Date	0000-00-00 00:00:00	⇒	2018-12-01 18:08:41
Closed_By		⇒	mbabker
Labels	Added: ?

mbabker - close - 1 Dec 2018

mbabker - merge - 1 Dec 2018

Joomla! Issue Tracker - CMS

[#20584] - Change spacer's tooltip from tooltip to popover

Pending

Summary of Changes

Testing Instructions

Expected result

Actual result

Documentation Changes Required

-------BEFORE--------

--------AFTER--------

Add a Comment

	$equals = '<span class="spacer"><span class="before"></span><span>' .
	'<label id="spacer-lbl" class="hasTooltip" title="<strong>spacer</strong>">spacer</label></span>' .
	'<span class="after"></span></span>';