? ? ?

Pending

User tests: Successful: Unsuccessful:

avatar Quy
Quy
26 May 2018

Pull Request for Issue #19604 .

Summary of Changes

Change spacer's tooltip from tooltip to popover to match the other form fields.

Testing Instructions

Edit file \administrator\components\com_content\models\forms\article.xml
Change line 847 from:

		<field
			name="spacer1"
			type="spacer"
			hr="true"
		/>

to:

		<field
			name="spacer1"
			type="spacer"
			label="Label"
			description="This is a description"
		/>

Log in the backend
Edit an article
Under Images and Links, hover over Label

Expected result

Tooltip as popover

Actual result

Tooltip as tooltip

Documentation Changes Required

none

avatar Quy Quy - open - 26 May 2018
avatar Quy Quy - change - 26 May 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 26 May 2018
Category Libraries
avatar infograf768
infograf768 - comment - 28 May 2018

Works fine here.
before
screen shot 2018-05-28 at 07 42 28
after
screen shot 2018-05-28 at 07 40 59

Please correct JFormFieldSpacerTest.php (line 122) as Travis is not happy ;)

avatar carlitorweb
carlitorweb - comment - 7 Jun 2018

-------BEFORE--------

screenshot_20180607192551

--------AFTER--------

screenshot_20180607192658

avatar carlitorweb carlitorweb - test_item - 7 Jun 2018 - Tested successfully
avatar carlitorweb
carlitorweb - comment - 7 Jun 2018

I have tested this item successfully on bffb7dd


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20584.

avatar franz-wohlkoenig franz-wohlkoenig - alter_testresult - 27 Aug 2018 - infograf768: Tested successfully
avatar franz-wohlkoenig franz-wohlkoenig - change - 27 Aug 2018
Status Pending Ready to Commit
avatar SharkyKZ
SharkyKZ - comment - 20 Nov 2018

RTC?

avatar infograf768
infograf768 - comment - 20 Nov 2018

Relaunched Travis

avatar infograf768
infograf768 - comment - 20 Nov 2018

This PR is now useless. popovers have been implemented since.
Closing.

avatar infograf768 infograf768 - change - 20 Nov 2018
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2018-11-20 09:56:16
Closed_By infograf768
Labels Added: ? ?
avatar infograf768 infograf768 - close - 20 Nov 2018
avatar SharkyKZ
SharkyKZ - comment - 20 Nov 2018

This PR is fine. Spacer does not have popovers in current staging.

avatar infograf768
infograf768 - comment - 20 Nov 2018

reopening, but we have issues with tests in Travis.

avatar SharkyKZ
SharkyKZ - comment - 20 Nov 2018

Need to update test.

$equals = '<span class="spacer"><span class="before"></span><span>' .
'<label id="spacer-lbl" class="hasTooltip" title="&lt;strong&gt;spacer&lt;/strong&gt;">spacer</label></span>' .
'<span class="after"></span></span>';

avatar infograf768
infograf768 - comment - 20 Nov 2018

@Quy
Can you modify the test file?

avatar Quy Quy - change - 21 Nov 2018
Labels Removed: ?
avatar joomla-cms-bot joomla-cms-bot - change - 21 Nov 2018
Category Libraries Libraries Unit Tests
avatar Quy Quy - change - 25 Nov 2018
Labels Added: ?
avatar SharkyKZ
SharkyKZ - comment - 26 Nov 2018

I have tested this item successfully on 40d0517


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20584.

avatar SharkyKZ SharkyKZ - test_item - 26 Nov 2018 - Tested successfully
avatar SharkyKZ
SharkyKZ - comment - 26 Nov 2018

This issue is still closed on the Issue Tracker.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20584.

avatar infograf768 infograf768 - change - 26 Nov 2018
Status Closed Pending
Closed_Date 2018-11-20 09:56:16
Closed_By infograf768
Labels
avatar infograf768
infograf768 - comment - 26 Nov 2018

Reopened as pending on Issues Tracker and relaunched Drone.

avatar infograf768
infograf768 - comment - 26 Nov 2018

I have tested this item successfully on 40d0517


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20584.

avatar infograf768 infograf768 - test_item - 26 Nov 2018 - Tested successfully
avatar infograf768 infograf768 - change - 26 Nov 2018
Status Pending Ready to Commit
avatar infograf768
infograf768 - comment - 26 Nov 2018

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20584.

avatar infograf768
infograf768 - comment - 26 Nov 2018

@mbabker
I guess this can go in stable as totally B/C

avatar mbabker mbabker - change - 1 Dec 2018
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2018-12-01 18:08:41
Closed_By mbabker
Labels Added: ?
avatar mbabker mbabker - close - 1 Dec 2018
avatar mbabker mbabker - merge - 1 Dec 2018

Add a Comment

Login with GitHub to post a comment