[#20580] - Update to allow for - character in attribute name
- Closed
- 26 May 2018
- Medium
- Build: staging
- # 20580
- Diff
- ryandemmer:patch-2
User tests: Successful: Unsuccessful:
Line 867 introduced in Joomla 3.8.8 attempts to clean up attribute names in an HTML tag by removing all symbols. This change removes the - character, which is valid in attribute names and required for data attributes, eg: data-value="1"
Pull Request for Issue #20579
Summary of Changes
This PR excludes the dash character form the symbols removed from attribute names by the input filter.
Testing Instructions
While logged in as a Super User:
In the Global Configuration, set the Default Editor to Editor - None.
In the Text Filters tab, set the Filter Type value to Default BlackList for the Super User group.
Save.
Go to Content -> Articles -> Add New Article.
Give the new article a Title, and add the following HTML, or a variation of it, to the Content field:
<p data-value="1">Some text</p>Click the Save button.
Expected result
The article should be save with the original content added intact.
<p data-value="1">Some text</p>Actual result
The hyphen is removed from the data attribute, resulting in
<p datavalue="1">Some text</p>Documentation Changes Required
None.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | External Library Libraries Composer Change |
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-05-26 15:56:14 |
| Closed_By | ⇒ | mbabker | |
| Labels |
Added:
?
?
|
||
Thanks
Would you mind sending a PR to https://github.com/joomla-framework/filter instead, that way the change doesn't get lost here next time a
composer updateis run against this repo? And if possible include a unit test case (similar to joomla-framework/filter@4bb9de8 it doesn't need to be anything special).