User tests: Successful: Unsuccessful:
Pull Request for Issue #20530
Runs the build/deleted_file_check.php
across minor versions all the way back to the oldest git release tag we have.
php build/deleted_file_check.php --from=1.7.3 --to=2.5.0
php build/deleted_file_check.php --from=2.5.0 --to=3.0.0
php build/deleted_file_check.php --from=3.0.0 --to=3.1.0
php build/deleted_file_check.php --from=3.1.0 --to=3.2.0
php build/deleted_file_check.php --from=3.2.0 --to=3.3.0
php build/deleted_file_check.php --from=3.3.0 --to=3.4.0
php build/deleted_file_check.php --from=3.4.0 --to=3.5.0
php build/deleted_file_check.php --from=3.5.0 --to=3.6.0
php build/deleted_file_check.php --from=3.6.0 --to=3.7.0
php build/deleted_file_check.php --from=3.7.0 --to=3.8.0
php build/deleted_file_check.php --from=3.8.0 --to=3.8.8
Also tried to group things a bit better for maintainability
Unfortunately this isn't the easiest diff to review because a lot of lines are reorganized, you might be best off reviewing the actual file.
Status | New | ⇒ | Pending |
Category | ⇒ | Administration com_admin |
Just review it. Otherwise build a release package from the branch, test an update from any old release, and make sure the update applies. Unless you REALLY want to explicitly test that every file listed in this listing actually gets removed by applying updates.
Given that this worked before I'm not sure if that is correct.
It is not that the file deletions never worked. It is that some files were missing from the list to be deleted. I ran across 3 sites that were updated from 2.5 to 3.0 (and forward to 3.8) which NEVER had libraries/cms/feed
deleted (added in 3.0.0 and moved to libraries/joomla/feed
in 3.1.0) which were using the 3.0.3 version of the feed classes and not the 3.8.7 version of the classes as a result. So, this simply runs the git diff for every minor release branch and ensures that all files are in the array, nothing more and nothing less.
Status | Pending | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-05-30 14:34:06 |
Closed_By | ⇒ | rdeutz | |
Labels |
Added:
?
|
@mbabker Do you have an idea how we can test this? Could an upgrade from 2.5.0 to 3.8.8 help? Given that this worked before I'm not sure if that is correct. Or do we need to check any possible release in between?