? Error

User tests: Successful: Unsuccessful:

avatar rawcat
rawcat
23 Sep 2013

Enabling the element tag selector from the 'advanced' section of the options panel of the module.

avatar rawcat rawcat - open - 23 Sep 2013
avatar brianteeman
brianteeman - comment - 13 Oct 2013

Thanks for your contribution - At this time we are only using github as the place to submit code fixes, the actual reporting of issues and testing fixes is still taking place on Joomlacode.

Please can you:

1) Open an item on the Joomlacode tracker in the appropriate area.

CMS Bug Reports: http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemBrowse&tracker_id=8103

CMS Feature Requests: http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemBrowse&tracker_id=8549

2) After submitting the item to the Joomlacode tracker, add a link to the Joomlacode tracker item here and make sure that you add a link to this GitHub issue or pull request on the joomlacode tracker item.

avatar Bakual
Bakual - comment - 9 May 2014

@rawcat I don't think this parameter should be applied here.
The parameter is meant for the module chrome like in the html5 chrome. (see https://github.com/joomla/joomla-cms/blob/staging/templates/system/html/modules.php#L35).

Unfortunately that's the only module chrome in core which supports the tag. But other templates may support it. If you use such a template (or the html5 chrome) and apply the parameter also in the module itself, you would end up with a doubled article or section tag (or whatever you selected), which would be not what you want.

avatar roland-d
roland-d - comment - 11 Jun 2014

@bakual: Is this code actually used in Joomla!? I can't seem to find any reference to it.

avatar Bakual
Bakual - comment - 11 Jun 2014

The module_tag parameter? It's used if you change the "Module Tag" in the "Advanced" tab of the module settings to "html5"
Inspect the source after you changed it and see that it gets doubled.

avatar brianteeman brianteeman - change - 21 Aug 2014
Status New Pending
Build .
avatar wilsonge
wilsonge - comment - 23 Dec 2014

I agree with the comments made here. This is not what that param is designed for. If you want to control that div then you should template override. Thankyou very much for your contribution but I'm going to close this one!

avatar wilsonge wilsonge - close - 23 Dec 2014
avatar wilsonge wilsonge - change - 23 Dec 2014
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2014-12-23 00:26:17

Add a Comment

Login with GitHub to post a comment