? ? Pending

User tests: Successful: Unsuccessful:

avatar Hackwar
Hackwar
21 May 2018

The suggestions in Smart Search currently throw an error, because the controller can't find the right model. This fixes that.

Testing instructions

  1. Build the index in the backend.
  2. Go to the frontend to the Smart Search view and type in "joo". Notice nothing is happening.
  3. Apply patch
  4. Type in "joo" and see that you get lots of suggestions.
avatar Hackwar Hackwar - open - 21 May 2018
avatar Hackwar Hackwar - change - 21 May 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 21 May 2018
Category Front End com_finder
avatar carlitorweb
carlitorweb - comment - 22 May 2018

I have tested this item successfully on 2194013


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20523.

avatar carlitorweb carlitorweb - test_item - 22 May 2018 - Tested successfully
avatar infograf768
infograf768 - comment - 22 May 2018

Firefox:
I lose focus when entering letters in the module field. I have to go back into it to add a letter.
finder_anim

And then, when I click on one of the results and click search I get a 404 and this
1055 'joomla_db_finder.t.parent_id' isn't in GROUP BY

avatar carlitorweb
carlitorweb - comment - 22 May 2018

@infograf768 I think this bug you mention is for a new issue. This PR is just for match the right model.

avatar infograf768
infograf768 - comment - 23 May 2018

I have tested this item successfully on 2194013

For what it does, OK here.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20523.

avatar infograf768 infograf768 - test_item - 23 May 2018 - Tested successfully
avatar Hackwar
Hackwar - comment - 23 May 2018

@infograf768 The search issue that you mentioned is fixed in #20185. This here is only about suggestions.

avatar Quy Quy - change - 23 May 2018
Status Pending Ready to Commit
avatar Quy
Quy - comment - 23 May 2018

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20523.

avatar laoneo laoneo - change - 23 May 2018
Labels Added: ?
avatar laoneo laoneo - change - 23 May 2018
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2018-05-23 11:58:05
Closed_By laoneo
Labels Added: ?
avatar laoneo laoneo - close - 23 May 2018
avatar laoneo laoneo - merge - 23 May 2018

Add a Comment

Login with GitHub to post a comment