Please change customise https://github.com/joomla/joomla-cms/pull/20515/files#diff-08b8aee1d43899c68aa8a784f98becb5R85

LGTM - are you planning on addressing the other two issues @Quy raised @brianteeman ? They're slightly less related to the main PR so I'm easy either way - just don't want to prematurely merge :)

Not sure we should merge this now as we have quite a few code descrepancies vs lang strings that we should solve altogether if possible.

Examples:
<h3><?php echo JText::_('Do you want to install sample data?'); ?></h3> // We DO need a lang string for that one.
and
$setting->label = \JText::_('INSTL_MAGIC_QUOTES_RUNTIME'); // string missing but do we use it?

@infograf768 think I have caught all the missing strings now.

INSTL_MAGIC_QUOTES_RUNTIME is missing when we look at code.
INSTL_MAGIC_QUOTES_RUNTIME="Magic Quotes Runtime"

In the context of 4.0 there really should be no references to Magic Quotes Runtime. PHP 5.4 removed it.

That is really beyond the scope of the intent of this PR but i have removed it

It only caught my eye because it was pointed out the string was missing.

Please also take it off from UpdateModel.php so that we are done with it.

@infograf768 already done in a seperate pr

Thanks!

Thanks