? Pending

User tests: Successful: Unsuccessful:

avatar rdeutz
rdeutz
20 May 2018

Pull Request for Issue #20448

Summary of Changes

Just added the trait as other classes do

Testing Instructions

see #20448

avatar rdeutz rdeutz - open - 20 May 2018
avatar rdeutz rdeutz - change - 20 May 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 20 May 2018
Category Libraries
avatar infograf768
infograf768 - comment - 20 May 2018

This does not break #20448 . I would not know how to test it specifically.

avatar laoneo
laoneo - comment - 20 May 2018

But then we should remove the trait from the CMSApplication and pass the container to the web application in the constructor.

avatar rdeutz rdeutz - change - 20 May 2018
Labels Added: ?
avatar rdeutz
rdeutz - comment - 20 May 2018

@Quy shouldn't phpcs have catch this?

avatar Quy
Quy - comment - 20 May 2018

I don't know. Let's check with @photodude

avatar photodude
photodude - comment - 20 May 2018

@Quy @rdeutz, I'm not sure if the PHPCS 1.5.x version currently used on the CMS would catch that missing space after the comma in the use list. I believe the PHPCS2.x and 3.x versions should, but I haven't run a specific test to verify. The PHPCS2.x and 3.x versions are much more accurate and are more likely to catch the code style errors.

We need to finish cleaning up the existing CMS code style violations so we make the move to the PHPCS2.x and 3.x versions. (I've been busy and haven't had time to work on it recently)

avatar rdeutz rdeutz - change - 20 Jul 2018
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2018-07-20 19:28:11
Closed_By rdeutz
avatar rdeutz rdeutz - close - 20 Jul 2018

Add a Comment

Login with GitHub to post a comment