User tests: Successful: Unsuccessful:
Status | New | ⇒ | Pending |
Category | ⇒ | Libraries |
But then we should remove the trait from the CMSApplication and pass the container to the web application in the constructor.
Labels |
Added:
?
|
I don't know. Let's check with @photodude
@Quy @rdeutz, I'm not sure if the PHPCS 1.5.x version currently used on the CMS would catch that missing space after the comma in the use
list. I believe the PHPCS2.x and 3.x versions should, but I haven't run a specific test to verify. The PHPCS2.x and 3.x versions are much more accurate and are more likely to catch the code style errors.
We need to finish cleaning up the existing CMS code style violations so we make the move to the PHPCS2.x and 3.x versions. (I've been busy and haven't had time to work on it recently)
Status | Pending | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-07-20 19:28:11 |
Closed_By | ⇒ | rdeutz |
This does not break #20448 . I would not know how to test it specifically.