[#20499] - [4.0] unstyled modal closed button (hardly used)
- Closed
- 11 Jul 2018
- Medium
- Build: staging
- # 20499
Steps to reproduce the issue
install from 4.0-dev at 79fd949
login as super admin to admin
go to user notes and try and add a new user note
next to user click the select user button
Expected result
styled modal CLOSE button like the others in joomla
Actual result
unstyled CANCEL button
(for comparison here is the one from the select category modal)
System information (as much as possible)
79fd949
google chrome
| Labels |
Added:
?
|
||
| Status | New | ⇒ | Discussion |
| Category | ⇒ | Layout Templates (admin) |
brianteeman
- | Labels |
Added:
J4 Issue
|
||
| Status | Discussion | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-05-23 19:53:32 |
| Closed_By | ⇒ | joomla-cms-bot |
| Closed_By | joomla-cms-bot | ⇒ | Quy |
Set to "closed" on behalf of @Quy by The JTracker Application at issues.joomla.org/joomla-cms/20499
Seriously you need to stop closing issues just because you - ONE - person cannot replicate an issue!
Your button is unstyled.
I can STILL replicate this - watch this video - compare the close/cancel buttons on the select user and select category modals - they are styled different - the one is different to all the rest of joomla!
higher res gif here http://screenshot.myjoom.la/0y0q0T2d011y
see the difference: -HUGE difference!
| Status | Closed | ⇒ | Pending |
| Closed_Date | 2018-05-23 19:53:32 | ⇒ | |
| Closed_By | Quy | ⇒ |
| Status | Pending | ⇒ | New |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ |
Set to "open" on behalf of @Quy by The JTracker Application at issues.joomla.org/joomla-cms/20499
Seriously you need to stop closing issues just because you - ONE - person cannot replicate an issue!
Sorry. Please advise which other issues that should have not been closed prematurely.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20499.
one earlier today ... got lost in all my gdpr emails... cant find it now.
i prefer closing Issues if not confirmed as they always can be reopened if needed. So Danger of open but abandoned Issues is in this Way less.
However the issue Im thinking was confirmed by @franz-wohlkoenig and then closed by @Quy with no explanation at all, apart from he could not replicate it himself. He did not state which git ref/branch/version he tested with or anything - just a abrupt cant reproduce and then he hit closed. Hardly the right way to reject CONFIRMED issues.
If you are going to close an issue with two words "cant reproduce" then at least say what you tested, on what git ref, and if you are the only one that cannot reproduce something that is not a reason to close an issue - OTHERS MIGHT with different configurations, browsers, or skills, be able to reproduce it.
If you go around just closing things on the say of one mans 2 words then there will be no open issues left!
It seems 2 successful tests are needed for PR to merge something, but we only require one persons test of an issue to reject it, even if others confirm it.
I provided screenshots for the 2 "can't reproduce" so it is more than just "2 words" without context and the other one I referenced it to another issue. Please advise which one(s) should be reopened.
Thanks for the feedback. I will provide testing information for future closed issues.
| Status | New | ⇒ | Discussion |
| Status | Discussion | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-07-11 18:46:32 |
| Closed_By | ⇒ | joomla-cms-bot |
| Closed_By | joomla-cms-bot | ⇒ | Quy |
Set to "closed" on behalf of @Quy by The JTracker Application at issues.joomla.org/joomla-cms/20499
Please test #21079
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20499.
Not reproducible