? ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
19 May 2018

Small tweaks to the language file.

@zero-24 we could make the strings even simpler and the tool easier to use if the HTTP-Header field was a select of the supported values instead of a free text field - thoughts?

avatar brianteeman brianteeman - open - 19 May 2018
avatar brianteeman brianteeman - change - 19 May 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 19 May 2018
Category Administration Language & Strings
avatar brianteeman brianteeman - change - 19 May 2018
Labels Added: ? ?
avatar Quy
Quy - comment - 19 May 2018

I have tested this item successfully on d9c1940


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20459.

avatar Quy Quy - test_item - 19 May 2018 - Tested successfully
avatar zero-24
zero-24 - comment - 19 May 2018

we could make the strings even simpler and the tool easier to use if the HTTP-Header field was a select of the supported values instead of a free text field - thoughts?

Yes this could be possible. But I would suggest to do this in a separate PR as this also requires PHP code to change ;)

avatar brianteeman
brianteeman - comment - 19 May 2018

Obviously made an error doing this from my phone. Closing now and will redo it later or if you think the select is a good idea then I can do new strings after/with that. We don't need to list supported headers in the text any more then as it will be obvious from the select

avatar brianteeman brianteeman - change - 19 May 2018
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2018-05-19 20:40:08
Closed_By brianteeman
avatar brianteeman brianteeman - close - 19 May 2018
avatar zero-24
zero-24 - comment - 19 May 2018

Ok I'm going to propose a PR. So we can include the language changes there too.

avatar brianteeman
brianteeman - comment - 19 May 2018

Great

avatar zero-24
zero-24 - comment - 19 May 2018

Done: #20491 just let me know what you want to have in there concerning the language strings.

avatar brianteeman
brianteeman - comment - 19 May 2018

Great. I Will

Add a Comment

Login with GitHub to post a comment