? Pending

User tests: Successful: Unsuccessful:

avatar laoneo
laoneo
18 May 2018

Moves com_associations to the service based extension setup.

See #20217 for details.

avatar laoneo laoneo - open - 18 May 2018
avatar laoneo laoneo - change - 18 May 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 18 May 2018
Category Administration com_associations com_modules
avatar infograf768 infograf768 - change - 19 May 2018
Labels Added: ?
avatar infograf768
infograf768 - comment - 19 May 2018

Tested: No noticeable change after this PR (I mean same issues as before).
(To test, one has first to patch with #20448 )

avatar laoneo
laoneo - comment - 19 May 2018

Thanks for the test.

avatar wilsonge
wilsonge - comment - 19 May 2018

Can we/should we have a library class for the component classes that are just MVCFactory aware? Because we're going to have com_cpanel, com_modules, com_plugins, com_associations etc all having exactly the same classname, which seems kinda pointless (to be clear a generic version of https://github.com/Digital-Peak/joomla-cms/blob/9c95d4ece19fe25697fcecce8cb98c25d8b71d8a/administrator/components/com_associations/Extension/AssociationsComponent.php)

avatar joomla-cms-bot joomla-cms-bot - change - 20 May 2018
Category Administration com_associations com_modules Administration com_admin com_associations com_content com_modules Libraries
avatar laoneo
laoneo - comment - 20 May 2018

@wilsonge good input. Changed and could remove two more classes.

avatar laoneo
laoneo - comment - 21 May 2018

Synced

avatar wilsonge wilsonge - change - 24 May 2018
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2018-05-24 13:53:35
Closed_By wilsonge
avatar wilsonge wilsonge - close - 24 May 2018
avatar wilsonge wilsonge - merge - 24 May 2018

Add a Comment

Login with GitHub to post a comment