[#20454] - [4.0] Installation text improvement
- Fixed in Code Base
- 18 May 2018
- Medium
- Build: 4.0-dev
- # 20454
- Diff
- joomlara:joomlara-patch-1
User tests: Successful: Unsuccessful:
Pull Request for Issue #20351.
Summary of Changes
Text improvement for the "Congratulations" page of the installation process.
Testing instructions
Go through the installation proces and check if the correct new message appears on the Congratulations page.
Old text: Before going on to your site you have the chance to pre-configure some features to your Joomla installation.
New text: You now have the option to customise your installation by adding another language or installing the sample data.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Installation Language & Strings |
| Labels |
Added:
?
?
|
||
Ok, thanks @carlitorweb !
Nice one!
Congratulations on your first pr.
I don't think we need the second sentence. The UI already does it.
Just the text I wrote here #20351 (comment) is enough. Less is always better.
Thanks @brianteeman and also for your help!
Do you mean the sentence "If you are not interested just skip this step...."? If so, I will delete it.
Or do I have to create a new branch then?
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20454.
Just delete that part
On Fri, 18 May 2018, 16:59 Lara Bettelheim, notifications@github.com
wrote:
Thanks @brianteeman https://github.com/brianteeman and also for your
help!
Do you mean the sentence "If you are not interested just skip this
step...."? If so, I will delete it.
Or do I have to create a new branch then?This comment was created with the J!Tracker Application
https://github.com/joomla/jissues at
issues.joomla.org/tracker/joomla-cms/20454.—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#20454 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8Q5rzem5pfmjjoC8YAhxXCFgRhZHks5tzuHjgaJpZM4UEoXf
.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20454.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20454.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20454.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-05-18 16:35:09 |
| Closed_By | ⇒ | laoneo | |
| Labels |
Added:
?
|
||
Thank you! #jab18
Congratulations on successfully completing your first merged pr. I hope this is the first of many
Thanks Brian! Wow, merged on the same day...
Thanks everyone, for testing, merging my first PR so quickly!
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20454.
@brianteeman @laoneo Is it ok like this? I thought the code would be added to the original issue, or is this normal?
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20454.