? Pending

User tests: Successful: Unsuccessful:

avatar zero-24
zero-24
17 May 2018

Summary of Changes

This PR adds the new line requested by @laoneo and is going to include the language changes that @brianteeman is going to request on #20403

Language file in question is this one: https://github.com/joomla/joomla-cms/blob/4.0-dev/administrator/language/en-GB/en-GB.plg_system_httpheaders.ini

Expected result

Passes @laoneo 's and @brianteeman 's review.

avatar zero-24 zero-24 - open - 17 May 2018
avatar zero-24 zero-24 - change - 17 May 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 17 May 2018
Category Front End Plugins
avatar wilsonge wilsonge - change - 17 May 2018
Title
[4.0] Add the requested new line & await en-GB review
[4.0][WIP] Add the requested new line & await en-GB review
avatar wilsonge wilsonge - edited - 17 May 2018
avatar zero-24
zero-24 - comment - 18 May 2018

@brianteeman this was about the language strings you want to change in that plugin. Or does this mean that the strings are fine now?

avatar brianteeman
brianteeman - comment - 18 May 2018

ah - i will do a pr for those strings but it wont be until i am back from france

avatar zero-24
zero-24 - comment - 18 May 2018

Ok thanks have a great time in France! Than this is ready to be merged cc @wilsonge ;)

avatar zero-24 zero-24 - change - 18 May 2018
Title
[4.0][WIP] Add the requested new line & await en-GB review
[4.0] Add the requested new line & await en-GB review
avatar zero-24 zero-24 - edited - 18 May 2018
avatar zero-24 zero-24 - change - 18 May 2018
Labels Added: ?
avatar wilsonge wilsonge - change - 19 May 2018
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2018-05-19 22:18:15
Closed_By wilsonge
avatar wilsonge wilsonge - close - 19 May 2018
avatar wilsonge wilsonge - merge - 19 May 2018
avatar wilsonge
wilsonge - comment - 19 May 2018

Thanks :)

Add a Comment

Login with GitHub to post a comment