Feeling Lucky
?
?
[#20441] - Add PHP 7.3 polyfill
- Fixed in Code Base
- 17 May 2018
- Medium
- Build: staging
- # 20441
- Diff
- mbabker:polyfill-countable
User tests: Successful: Unsuccessful:
Summary of Changes
PHP 7.2 got strict about running count() on non-countable things. PHP 7.3 adds a helper function to actually check for countability. This imports the polyfill to be able to use that function.
Testing Instructions
Any place in the code where you need to count something and you're not sure the value is countable, run is_countable($thing);, if true you can safely run count($thing).
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | External Library Composer Change Libraries Repository |
| Labels |
Added:
?
?
|
||
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-05-17 19:46:57 |
| Closed_By | ⇒ | zero-24 |
We might need to put a leading slash on all the lines in CODEOWNERS. You should only get pinged on the root README, this pinged because I (wrongly) committed the upstream README.