[#20422] - [plg_fields] Manifest cleanup, filters, Editor plugin fix
- Fixed in Code Base
- 24 May 2018
- Medium
- Build: staging
- # 20422
- Diff
- SharkyKZ:plg_fields_1
- Pending continuous-integration/drone/pr this build is pending Details
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
Added filter attribute to some XML fields.
Fixed 'Show Buttons' option in Editor field.
Some CS (hidden tabs and spaces).
Testing Instructions
-
Code review.
-
In
Fields - Editorplugin setShow Buttonsoption toYes. Create editor type field, setShow ButtonstoUse settings from plugin. Edit an article, inFieldstab check the editor field.
Expected result
- Buttons are shown.
Actual result
- Buttons not shown.
Documentation Changes Required
No.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End Plugins |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20422.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20422.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20422.
| Labels |
Added:
?
|
||
Restored empty values. Although it makes no difference in terms of functionality, I guess it makes sense to keep it for readability and consistency.
I prefer without, but it's more explicit by adding it to the XML.
Thanks
mbabker
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-05-24 00:01:11 |
| Closed_By | ⇒ | mbabker | |
| Labels |
Added:
?
|
||
I have tested this item✅ successfully on bb646a9
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20422.